Adding new pipelines deploy command#3107
Merged
Merged
Conversation
alyssa-db
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
alyssa-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alyssa-db
commented
Jun 23, 2025
kanterov
reviewed
Jun 24, 2025
Collaborator
kanterov
left a comment
kanterov
left a comment
There was a problem hiding this comment.
Agree with Andrew on not reusing the implementation as-is. I think as a principle we want to duplicate CLI commands, and customize which options they accept instead of reusing. We can extract sensible pieces of code to be shared, for example, mutator pipeline for deployment.
alyssa-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alyssa-db
force-pushed
the
pipelines-deploy
branch
from
2668f34 to
365a31e
Compare
alyssa-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alyssa-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alyssa-db
force-pushed
the
pipelines-deploy
branch
from
5484a66 to
64ef843
Compare
alyssa-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alyssa-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alyssa-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alyssa-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alyssa-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
jefferycheng1
approved these changes
Jul 4, 2025
Collaborator
|
@kanterov seems like alyssa resolved the comments, forgot to re-request, mind taking another look? |
## Changes Added acceptance test for rendering diagnostics warnings when unknown properties are encountered during pipeline deployment. ## Why Follow-up to [PR #3107](#3107) - ensures the diagnostics system correctly identifies and reports unknown properties in pipeline configurations, providing users with helpful feedback about potential configuration issues. ## Tests Added acceptance test case `render-diagnostics-warning` that verifies warning messages are properly displayed for unknown bundle configuration properties.
kanterov
approved these changes
Jul 7, 2025
denik
pushed a commit
that referenced
this pull request
May 20, 2026
## Changes Adds `pipelines deploy` command with: - `--auto-approve` flag for non-interactive deployments - `--force-lock` flag to override deployment locks - `--var` flag for runtime variable substitution - `--verbose` flag for detailed output (VSCode integration) ## Why Enables direct pipeline deployment from CLI with safety controls and CI/CD support, eliminating need to switch tools for deployment workflows. ## Tests Added acceptance tests covering: - Auto-approve behavior for destructive operations - Force lock functionality and concurrent deployment handling - Variable substitution with special characters, unicode, and precedence rules - Error cases for undefined variables and invalid formats - Basic deployment and recreation scenarios All tests run against Terraform backend with proper cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds
pipelines deploycommand with:--auto-approveflag for non-interactive deployments--force-lockflag to override deployment locks--varflag for runtime variable substitution--verboseflag for detailed output (VSCode integration)Why
Enables direct pipeline deployment from CLI with safety controls and CI/CD support, eliminating need to switch tools for deployment workflows.
Tests
Added acceptance tests covering:
All tests run against Terraform backend with proper cleanup.