Convert python_wheel_test.go to acceptance test by denik · Pull Request #2471 · databricks/cli

denik · 2025-03-11T15:03:18Z

Convert integration/bundle/integration/bundle/python_wheel_test.go to acceptance tests. I plan to expand these tests to check patchwheel functionality.

Inside each test there were two runs - with params and without, I've expanded each run into separate test to reduce total time as this runs can be done in parallel.

Also add new env var DEFAULT_SPARK_VERSION that matches the one in integration tests.

The tests are currently enabled on every PR (CloudLong=true is commented out), this can be changed after landing.

## Changes New bool config setting CloudSlow in acceptance tests. If set, it enables this test on Cloud but skips it in -short setting there. It does not affect local runs, "Slow" is only applied to Cloud. The reason is that we won't need to wait for cluster with mocked testserver. Additionally, this setting enables -tail if -v is already enabled. ## Why Certain tests that use "bundle run" are too long due to starting a cluster. ## Tests Using this option in #2471

add repl for TEST_INSTANCE_POOL_ID add uuid1 env/repl with dashes replaced with underscore - WIP - use randomString rm out.requests.txt update test fix the test mark my test as CloudLong update test.toml disable local runs split test in two for parallel run rename

denik · 2025-03-12T08:27:53Z

-}
-
-func TestPythonWheelTaskDeployAndRunWithWrapper(t *testing.T) {
-	runPythonWheelTest(t, "python_wheel_task", "12.2.x-scala2.12", true)


@andrewnester why was this Spark version used in this test?

Installing wheels from Workspace file system is only supported starting from DBR 13.1+. But before users used older DBRs and python wheel tasks but installed it from DBFS. We still want to support older DBRs and did the trampoline workaround. Hence this is to test that python wheel tasks in DABs are working for older DBRs

Thanks! Added you comment into the test 060b8f5

denik · 2025-03-12T08:57:47Z

 import (
 	"bufio"
 	"context"
+	"encoding/base32"


all changes in acceptance_test.go will disappear after linked PRs are merged and this one is rebased.

Useful for integration tests where project names must be unique. I'm using it in #2471

Follow #2471 to where incorrect config is used. Modify all tests in integration_whl to print rendered databricks.yml Add $NODE_TYPE_ID env var.

…E_ID (#2478) This is a follow up to #2471 where incorrect config was used in interactive_cluster test. ## Changes - Fixed interactive_cluster to use proper config, it was accidentally referring to config from ../base - Add $NODE_TYPE_ID env var and replacement to acceptance tests, this is necessary for interactive_cluster test. - Disable acceptance/bundle/override on cloud. This started failing because it has real node type that gets replaced with NODE_TYPE_ID but only in AWS env. Since the test is focussed on config merging, there is no need to run it against real workspaces. - Modify all tests in integration_whl to print rendered databricks.yml, to prevent this kind of error.

When this tests were integration tests, they did not do run() part in -short mode. After converting them to acceptance I kept them on always in #2471 Disabling them in short mode because it seems they do expand PR integration test time.

## Why When this tests were integration tests, they did not do run() part in -short mode. After converting them to acceptance I kept them on always in #2471 This PR disables them in short mode (they will still run on main) because it seems they do expand PR integration test time.

## Changes New bool config setting CloudSlow in acceptance tests. If set, it enables this test on Cloud but skips it in -short setting there. It does not affect local runs, "Slow" is only applied to Cloud. The reason is that we won't need to wait for cluster with mocked testserver. Additionally, this setting enables -tail if -v is already enabled. ## Why Certain tests that use "bundle run" are too long due to starting a cluster. ## Tests Using this option in #2471

Discovered that 'trap' does not work with $CLI on Windows when working #2471 This example shows a workaround.

Using it in #2471

Useful for integration tests where project names must be unique. I'm using it in #2471

Convert integration/bundle/integration/bundle/python_wheel_test.go to acceptance tests. I plan to expand these tests to check patchwheel functionality. Inside each test there were two runs - with params and without, I've expanded each run into separate test to reduce total time as this runs can be done in parallel. Also add new env var DEFAULT_SPARK_VERSION that matches the one in integration tests. The tests are currently enabled on every PR (`CloudLong=true` is commented out), this can be changed after landing.

…E_ID (#2478) This is a follow up to #2471 where incorrect config was used in interactive_cluster test. ## Changes - Fixed interactive_cluster to use proper config, it was accidentally referring to config from ../base - Add $NODE_TYPE_ID env var and replacement to acceptance tests, this is necessary for interactive_cluster test. - Disable acceptance/bundle/override on cloud. This started failing because it has real node type that gets replaced with NODE_TYPE_ID but only in AWS env. Since the test is focussed on config merging, there is no need to run it against real workspaces. - Modify all tests in integration_whl to print rendered databricks.yml, to prevent this kind of error.

## Why When this tests were integration tests, they did not do run() part in -short mode. After converting them to acceptance I kept them on always in #2471 This PR disables them in short mode (they will still run on main) because it seems they do expand PR integration test time.

denik temporarily deployed to test-trigger-is March 11, 2025 15:03 — with GitHub Actions Inactive

denik changed the base branch from main to denik/acc-CloudLong March 11, 2025 15:03

denik mentioned this pull request Mar 11, 2025

acc: Add CloudSlow config setting #2470

Merged

denik temporarily deployed to test-trigger-is March 11, 2025 15:07 — with GitHub Actions Inactive

Base automatically changed from denik/acc-CloudLong to main March 11, 2025 15:48

denik added 2 commits March 11, 2025 16:51

integration test wip

0d04ff9

add repl for TEST_INSTANCE_POOL_ID add uuid1 env/repl with dashes replaced with underscore - WIP - use randomString rm out.requests.txt update test fix the test mark my test as CloudLong update test.toml disable local runs split test in two for parallel run rename

tmp comment out CloudSlow

2b5daea

denik force-pushed the denik/whl-run-acceptance-test branch from 31c7252 to 2b5daea Compare March 11, 2025 15:51

denik temporarily deployed to test-trigger-is March 11, 2025 15:51 — with GitHub Actions Inactive

denik added 2 commits March 11, 2025 16:56

update

3005e93

update

01e8eb4

denik temporarily deployed to test-trigger-is March 11, 2025 16:35 — with GitHub Actions Inactive

clean up python_wheel_task tests from integration

c55818a

denik temporarily deployed to test-trigger-is March 11, 2025 16:49 — with GitHub Actions Inactive

This was referenced Mar 11, 2025

acc: add replacement for $TEST_INSTANCE_POOL_ID #2473

Merged

acc: add $UNIQUE_NAME env var and replacement #2474

Merged

Add single quotes around $CLI

21f7bac

denik temporarily deployed to test-trigger-is March 11, 2025 17:43 — with GitHub Actions Inactive

denik mentioned this pull request Mar 11, 2025

acc: Add example on how to do trap #2475

Merged

denik commented Mar 12, 2025

View reviewed changes

Migrate TestPythonWheelTaskDeployAndRunOnInteractiveCluster

d533906

denik temporarily deployed to test-trigger-is March 12, 2025 08:44 — with GitHub Actions Inactive

fix script

a549009

denik temporarily deployed to test-trigger-is March 12, 2025 08:55 — with GitHub Actions Inactive

denik marked this pull request as ready for review March 12, 2025 08:57

denik requested review from andrewnester, pietern and shreyas-goenka as code owners March 12, 2025 08:57

denik commented Mar 12, 2025

View reviewed changes

move trap before deploy

b080fa8

denik temporarily deployed to test-trigger-is March 12, 2025 09:47 — with GitHub Actions Inactive

denik requested a review from andrewnester March 12, 2025 09:50

andrewnester approved these changes Mar 12, 2025

View reviewed changes

add a comment from Andrew wrapper

060b8f5

denik temporarily deployed to test-trigger-is March 12, 2025 09:59 — with GitHub Actions Inactive

Merge branch 'main' into denik/whl-run-acceptance-test

73415ed

denik temporarily deployed to test-trigger-is March 12, 2025 10:04 — with GitHub Actions Inactive

github-merge-queue Bot pushed a commit that referenced this pull request Mar 12, 2025

acc: add $UNIQUE_NAME env var and replacement (#2474)

f8f3d66

Useful for integration tests where project names must be unique. I'm using it in #2471

Merge branch 'main' into denik/whl-run-acceptance-test

72386a5

denik temporarily deployed to test-trigger-is March 12, 2025 10:23 — with GitHub Actions Inactive

denik enabled auto-merge March 12, 2025 10:24

denik added this pull request to the merge queue Mar 12, 2025

Merged via the queue into main with commit 8b51eeb Mar 12, 2025

denik deleted the denik/whl-run-acceptance-test branch March 12, 2025 10:58

denik added a commit that referenced this pull request Mar 12, 2025

Fix acc../interactive_cluster to use correct config

5ffac78

Follow #2471 to where incorrect config is used. Modify all tests in integration_whl to print rendered databricks.yml Add $NODE_TYPE_ID env var.

denik added a commit that referenced this pull request Mar 12, 2025

Fix acc../interactive_cluster to use correct config

a266bc1

Follow #2471 to where incorrect config is used. Modify all tests in integration_whl to print rendered databricks.yml Add $NODE_TYPE_ID env var.

denik mentioned this pull request Mar 12, 2025

acc: Fix interactive_cluster test to use correct config; add NODE_TYPE_ID #2478

Merged

denik mentioned this pull request Mar 18, 2025

Disable integration_whl tests on PRs #2514

Merged

denik added a commit that referenced this pull request May 20, 2026

acc: Add example on how to do trap (#2475)

5f3964b

Discovered that 'trap' does not work with $CLI on Windows when working #2471 This example shows a workaround.

denik added a commit that referenced this pull request May 20, 2026

acc: add replacement for $TEST_INSTANCE_POOL_ID (#2473)

8ee8f66

Using it in #2471

denik added a commit that referenced this pull request May 20, 2026

acc: add $UNIQUE_NAME env var and replacement (#2474)

94f781e

Useful for integration tests where project names must be unique. I'm using it in #2471

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert python_wheel_test.go to acceptance test#2471

Convert python_wheel_test.go to acceptance test#2471
denik merged 12 commits into
mainfrom
denik/whl-run-acceptance-test

denik commented Mar 11, 2025 •

edited

Loading

Uh oh!

denik Mar 12, 2025

Uh oh!

andrewnester Mar 12, 2025

Uh oh!

denik Mar 12, 2025

Uh oh!

denik Mar 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

denik commented Mar 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

denik Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

andrewnester Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

denik Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

denik Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

denik commented Mar 11, 2025 •

edited

Loading