Add CI check that vendored dbt-factory is byte-identical to upstream - #168
Open
park-peter wants to merge 2 commits into
Open
Add CI check that vendored dbt-factory is byte-identical to upstream#168park-peter wants to merge 2 commits into
park-peter wants to merge 2 commits into
Conversation
New workflow verifies the vendored databricks-dbt-factory copy has not drifted: each core file is byte-identical to the upstream commit named in NOTICE, the example and template copies are byte-identical to each other, and both NOTICE files cite the same commit. The upstream commit is read from NOTICE, so a version bump re-pins the check automatically.
pietern
reviewed
Aug 20, 2026
| pull_request: | ||
| types: [opened, synchronize] | ||
| merge_group: | ||
| types: [checks_requested] |
Contributor
There was a problem hiding this comment.
Please limit to the contrib/dbt factory path, so it only triggers when those paths are changed.
Only run on PRs that touch the vendored example or template (or the workflow itself), per review feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #163: a CI-only guard that the vendored
databricks-dbt-factorycopy has not drifted.What it checks
A new workflow (
.github/workflows/dbt-factory-vendor-sync.yml) verifies, on every PR and merge-group:contrib/dbt_factory/src/databricks_dbt_factory/matches the upstreamdatabricks-dbt-factoryrepo at the exact commit named inNOTICE.NOTICEfiles cite the same upstream commit.How it pins the version
The upstream commit is read from the
Adapted from: commit <sha> (vX.Y.Z)line incontrib/dbt_factory/NOTICE, so bumping the vendored version stays a one-line NOTICE change and the check re-pins to the new commit automatically — no workflow edit needed.Notes
actions/checkout) is SHA-pinned per the repo'spinned_actionspolicy.git fetch, so the check is fast and unambiguous.