ci: post evals-monitor link comment on new PRs#430
Draft
calvarjorge wants to merge 2 commits into
Draft
Conversation
Add a workflow that comments once on each opened/reopened PR with a small link to the evals-monitor PR page, where the author can start an eval. This replaces the direct CI-trigger approach (see closed #428): GitHub Actions runners can't reach the dogfood.staging workspace, so the app — which runs inside dogfood — performs the actual trigger instead. Co-authored-by: Isaac Signed-off-by: Jorge Calvar <jorge.calvar@databricks.com>
…ink) Co-authored-by: Isaac Signed-off-by: Jorge Calvar <jorge.calvar@databricks.com>
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Posts a small, one-time comment on every opened/reopened PR linking to the evals-monitor PR page, where the author can start an eval for their PR.
The comment renders as:
Why this approach
This replaces the direct CI-trigger approach (closed #428). GitHub Actions runners — including
databricks-protected-runner-group, even withid-token: write— cannot reach thedogfood.stagingworkspace; every request is rejected at the network perimeter with403 RBAC: access denied. Rather than fight that boundary, GitHub just posts a link, and the evals-monitor app (which runs inside dogfood and can reach everything) performs the actual trigger when the user clicks Start eval.Details
pull_requestopened/reopened(targetingmain).<!-- pr-eval-link -->marker and skips if already present, so reopen won't double-post.pull-requests: writeto post the comment.This pull request and its description were written by Isaac.