Repository navigation
[unsupervised AI] Reschedule P2P merges when an output shuffle closes - #9386
Draft
Minghan2005 wants to merge 1 commit into
Draft
Minghan2005 wants to merge 1 commit into
Minghan2005 wants to merge 1 commit into
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 40 files ± 0 40 suites ±0 14h 4m 59s ⏱️ + 13m 21s For more details on these failures, see this check. Results for commit d861cdf. ± Comparison against base commit dc182bd. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This PR was written autonomously by an AI agent and has not been reviewed
by a human yet. Maintainers should ignore it until the human author has reviewed,
understood, and approved everything that the AI agent wrote.
Closes #8660
pixi run lintChange
Use
handle_unpack_errorsseparately for the left and right output fetch inmerge_unpack, asshuffle_unpackalready does. A closed shuffle then raisesRescheduleinstead of failing the merge task. Other fetch errors retain theshared handler's policy and the corresponding shuffle ID.
The pandas merge remains outside both contexts. No scheduler logic, retry
configuration, public API, or dependencies change.
Tests
failures and eight passes. Both left/right closure integration cases failed.
python -m pytest distributed/shuffle/tests/test_merge.py --runslow -q:42 passed, zero skipped.
and Mypy passed. Codespell had no matching documentation files.
The integration cases run a real local scheduler, worker, P2P transfers, and
pandas merge. They inject one closed-output fetch on each side, require the
injection to occur, and compare the complete recovered result with pandas,
including duplicate-key multiplicity. Unit cases cover explicit rescheduling,
consistency/disk errors, other fetch errors, and unchanged merge errors.
Verification limits
Tests used Python 3.13.14, Dask 2026.8.0, pandas 3.1.1, and PyArrow 26.0.1 with
this checkout installed editable and the repository's pytest configuration and
plugins intact. The frozen Pixi environment setup timed out after 180 seconds;
no Pixi or
pixi run lintsuccess is claimed. The changed-file pre-commit runpassed instead. No full-repository or cross-platform test pass is claimed.
The deterministic one-shot fault injection verifies the merge task's recovery
contract; it does not simulate every worker-loss or closed-run lifecycle.