Use raw string literals if backslashes involved#37
Closed
maxnikulin wants to merge 1 commit intodanny0838:masterfrom
Closed
Use raw string literals if backslashes involved#37maxnikulin wants to merge 1 commit intodanny0838:masterfrom
maxnikulin wants to merge 1 commit intodanny0838:masterfrom
Conversation
Avoid ambiguity if backslashes start escape sequences.
Contributor
Author
|
I was checking if pytest could provide more informative report for #34 |
maxnikulin
commented
Dec 21, 2020
| """) | ||
|
|
||
| server.serve(server_root) | ||
| mock_browser.assert_called_once_with('"C:\Program Files\Mozilla Firefox\firefox.exe" %s &') |
Contributor
Author
There was a problem hiding this comment.
By the way, is there any protection against peculiar arguments for substitutions? On linux I strongly prefer something from execve(2) family that has each command line argument as a separate array element.
Path to firefox at least surrounded with quotes... Is it assumed that argument for the %s substitution is passed through urlencode, so it is safe?
danny0838
pushed a commit
that referenced
this pull request
Dec 21, 2020
Avoid ambiguity if backslashes start escape sequences.
Owner
|
Implemented with slightly fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid ambiguity if backslashes start escape sequences.