Fix for number 0 treated as invalid in hover#1
Merged
Conversation
| expect(hoverTrace.pointNumber).toEqual(17); | ||
| expect(hoverTrace.x).toEqual(0.388); | ||
| expect(hoverTrace.y).toEqual(1); | ||
| expect(hoverTrace.text).toEqual(0); |
There was a problem hiding this comment.
I see you're faithfully mimicking the previous test, but I'd prefer toBe instead of toEqual - lately I use toBe whenever possible, which I think includes all of these cases - especially for the 0, since some values we would find unacceptable would pass, like '' == 0, whereas toBe is stricter.
|
@dalle this looks great! Just a small comment, then feel free to open the PR against the main repo. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes plotly#2660.