Skip to content

add generator expressions to matcher for python argumentOrParameter - #633

Merged
pokey merged 15 commits into
cursorless-dev:mainfrom
AndrewDant:feature/generator_expression
Apr 26, 2022
Merged

add generator expressions to matcher for python argumentOrParameter#633
pokey merged 15 commits into
cursorless-dev:mainfrom
AndrewDant:feature/generator_expression

Conversation

@AndrewDant

Copy link
Copy Markdown
Collaborator

Closes #323

@AndrewDant
AndrewDant requested a review from pokey as a code owner April 16, 2022 05:23
Comment thread src/languages/python.ts
Comment thread src/languages/python.ts Outdated
Comment thread src/languages/python.ts Outdated

@pokey pokey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

Comment thread src/test/suite/fixtures/recorded/languages/python/chuckEveryArgRed.yml Outdated
Comment thread src/test/suite/fixtures/recorded/languages/python/chuckEveryArgWhale.yml Outdated
@pokey

pokey commented Apr 25, 2022

Copy link
Copy Markdown
Member

Oh yeah and sorry bout CI; will be fixed once I merge #638

@pokey

pokey commented Apr 25, 2022

Copy link
Copy Markdown
Member

pre-commit.ci autofix

pre-commit-ci Bot and others added 3 commits April 25, 2022 17:01
@AndrewDant

Copy link
Copy Markdown
Collaborator Author

I just pushed the latest round of changes.

@pokey pokey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@pokey
pokey merged commit d37cfb9 into cursorless-dev:main Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Argument scope type doesn't work in python when argument is a generator expression

3 participants