Skip to content

Remove use of constructor.name - #1580

Merged
pokey merged 6 commits into
mainfrom
constructor-name
Jul 9, 2023
Merged

Remove use of constructor.name#1580
pokey merged 6 commits into
mainfrom
constructor-name

Conversation

@AndreasArvidsson

@AndreasArvidsson AndreasArvidsson commented Jul 5, 2023

Copy link
Copy Markdown
Member

Fixes #1300

Checklist

@AndreasArvidsson
AndreasArvidsson marked this pull request as ready for review July 5, 2023 12:25
@AndreasArvidsson
AndreasArvidsson requested a review from pokey as a code owner July 5, 2023 12:25

@pokey pokey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great with one minor question

Comment thread packages/cursorless-engine/src/processTargets/targets/BaseTarget.ts Outdated
@pokey
pokey added this pull request to the merge queue Jul 9, 2023
Merged via the queue into main with commit 5253d4c Jul 9, 2023
@pokey
pokey deleted the constructor-name branch July 9, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop using constructor.name in targetToPlainObject

2 participants