fix(pstack): protect untracked and ignored worktree files - #459
Open
dajiaohuang wants to merge 3 commits into
Open
dajiaohuang wants to merge 3 commits into
dajiaohuang wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.
Reviewed by Cursor Bugbot for commit a17c461. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fixes #449.
Validation
Note
Medium Risk
Updates the human-gated worktree deletion playbook and audit lever; the changes are conservative but mistakes here could still block cleanup or mis-classify dirty state.
Overview
Worktree cleanup no longer treats untracked or ignored files as disposable “scratch.” The audit script now runs
git statuswith--untracked-files=alland--ignored=matching, and any non-clean worktree is labeledwip:N(line count) instead of splitting tracked vsscratch.The worktree-cleanup playbook steps 4–5 were rewritten to match: show tracked diffs and list untracked/ignored paths, default to keeping any
wipworktree until the user explicitly approves every path removal, and prune withgit worktree removeonly (no--force, norm -rf, nopruneto override Git refusals), with a status preflight right before each removal.Reviewed by Cursor Bugbot for commit 2310495. Bugbot is set up for automated code reviews on this repo. Configure here.