Issue with multiple children

[grxy]

I ran into the following problem where not all nested children would be visited:

This works

const A = ({ children }) => children
const B = ({ children }) => <div>{children}</div>

const tree = (
    <A>
        <B />
        <B />
    </A>
)

reactTreeWalker(tree, visitor, context)

So does this

const A = ({ children }) => <div>{children}</div>
const B = ({ children }) => children

const tree = (
    <A>
        <B />
        <B />
    </A>
)

reactTreeWalker(tree, visitor, context)

This does not work

Because there are no basic HTML elements wrapping the children of A, those individual children are not visited

const A = ({ children }) => children
const B = ({ children }) => children

const tree = (
    <A>
        <B />
        <B />
    </A>
)

reactTreeWalker(tree, visitor, context)

A PR will follow shortly and should provide a fix for this issue.

[ctrlplusb]

Hey @grxy

Awesome, thanks so much for picking this up. I'll try review and merge within the next 24 hours. 👍

[grxy]

@ctrlplusb No prob, dude. I actually noticed the issue when writing unit tests for my code while using this.

P.S. Great work breaking it out from react-apollo!

[ctrlplusb]

Hi @grxy 👋

Apologies for the late one on this.

I have struggled to recreate your initial issue. I have added another branch containing a test that I was initially expecting to fail as it doesn't have your fix applied. The test passes though.

Do you mind having a look to see if I have configured the test correctly?

Thanks!

[grxy]

@ctrlplusb The issue happens when you have multiple react components that are siblings, so if you updated your tree to be:

const tree = (
      <OnlyChildren something={1}>
        <OnlyChildren something={2}>
          <div>Hello world!</div>
        </OnlyChildren>
        <OnlyChildren something={3}>
          <div>Hello world!</div>
        </OnlyChildren>
      </OnlyChildren>
    )

you would expect actual to be [1, 2, 3], when in fact the children are never visited, resulting in actual being only [1]. See screenshot:

[ctrlplusb]

Perfect thanks!

[grxy]

@ctrlplusb Any chance you'll be able to merge my PR and publish 2.1.2 soon?

[ctrlplusb]

All done and published. Thanks for being persistent with me!

[grxy]

@ctrlplusb Great! Thank you!