Skip to content

feat(spc-config): Separate resolved and non-resolved functions in spc-config#1216

Merged
crazywhalecc merged 4 commits into
v3from
fix/spcconfig
Jul 21, 2026
Merged

feat(spc-config): Separate resolved and non-resolved functions in spc-config#1216
crazywhalecc merged 4 commits into
v3from
fix/spcconfig

Conversation

@crazywhalecc

Copy link
Copy Markdown
Owner

What does this PR do?

Checklist before merging

  • If you modified *.php or *.yml, run them locally to ensure your changes are valid:
    • composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:lint-config

@henderkes henderkes left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on the resolved path this acts the same way pgo-v3 does currently, I assume?

@crazywhalecc

crazywhalecc commented Jul 16, 2026

Copy link
Copy Markdown
Owner Author

on the resolved path this acts the same way pgo-v3 does currently, I assume?

This change primarily aims to avoid directly modifying config() and breaking the include_suggests option. Internally, we need the resolved result, so a separate method is better. This aligns with the approach in pgo-v3, but the details may differ.

I think we can perform full testing after merging #1214 and before merging this PR, and if there are no issues, continue migrating the changes from pgo-v3 based on this. feat/pgo-v3-split basically includes most of the modifications that are unrelated to spc-config, pgo, and the toolchain.

Base automatically changed from feat/pgo-v3-split to v3 July 21, 2026 08:32
@crazywhalecc crazywhalecc added need-test This PR has not been tested yet, cannot merge now sapi/frankenphp labels Jul 21, 2026
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

StaticPHP Test Bot

Detected: Extensions: rdkafka, swoole | Libraries: krb5, postgresql | Targets: none
Active labels: sapi/frankenphp
Available labels: need-test (gate), test/linux test/windows test/macos (platform), test/tier2 (extra arch), test/php-83 test/php-84 (PHP version), sapi/frankenphp (extra FrankenPHP SAPI build)
Config: Linux x86_64 + Windows x86_64 + macOS arm64 | PHP 8.5 NTS + SAPI: frankenphp (Tier1 Linux/macOS/Windows)

@crazywhalecc
crazywhalecc merged commit 171201f into v3 Jul 21, 2026
35 of 45 checks passed
@crazywhalecc
crazywhalecc deleted the fix/spcconfig branch July 21, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

need-test This PR has not been tested yet, cannot merge now sapi/frankenphp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants