Skip to content

misra.py: Fix 5.3 FP #2405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmar merged 3 commits into from
Nov 30, 2019
Merged

misra.py: Fix 5.3 FP #2405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fbc87c1
misra.py: Fix 5.3 FP
jubnzv Nov 28, 2019
8b88dae
fix names conflict
jubnzv Nov 28, 2019
2a3d90b
fix naming
jubnzv Nov 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions addons/misra.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -921,8 +921,6 @@ def misra_5_3(self, data):
continue
if int(innerVar.nameToken.linenr) > int(outerVar.nameToken.linenr):
self.reportError(innerVar.nameToken, 5, 3)
else:
self.reportError(outerVar.nameToken, 5, 3)
outerScope = outerScope.nestedIn
for scope in data.scopes:
if scope.className and innerVar.nameToken.str[:num_sign_chars] == scope.className[:num_sign_chars]:
Expand Down
10 changes: 10 additions & 0 deletions addons/test/misra/misra-test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,16 @@ void misra_5_3_func1(void)
}
}
void misra_5_3_enum_hidesfunction_31y(void) {} //5.3
extern bar_5_3(int i);
void f_5_3( void )
{
{
int i;
i = 42;
bar_5_3(i);
}
int i; // no warning
}


#define misra_5_4_macro_hides_macro__31x 1
Expand Down