Skip to content

fix: respect verbosity per GitHub Actions env var#346

Merged
2bndy5 merged 1 commit into
mainfrom
gh-verbose-logs
Jun 10, 2026
Merged

fix: respect verbosity per GitHub Actions env var#346
2bndy5 merged 1 commit into
mainfrom
gh-verbose-logs

Conversation

@2bndy5

@2bndy5 2bndy5 commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

This was an oversight when switching to git-bot-feedback in #304.

It restores the behavior in which verbosity is auto-enabled if the ACTIONS_STEP_DEBUG env var is asserted.

Summary by CodeRabbit

  • Chores
    • Enhanced debug logging configuration to respect REST client settings in addition to command-line verbosity options.

This was an oversight when switching to git-bot-feedback in #304.

It restores the behavior in which verbosity is auto-enabled if the `ACTIONS_STEP_DEBUG` env var is asserted.
@2bndy5 2bndy5 added the bug Something isn't working label Jun 10, 2026
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 37ca8702-83b0-471d-8c89-f4426c11dea4

📥 Commits

Reviewing files that changed from the base of the PR and between 45cfec0 and e61caef.

📒 Files selected for processing (2)
  • cpp-linter/src/rest_client/mod.rs
  • cpp-linter/src/run.rs

Walkthrough

RestClient exposes a new is_debug_enabled() method that queries the underlying client's debug status. The main run_main function integrates this check into its logging configuration, enabling Debug level when either CLI verbosity or the REST client's debug flag is true.

Changes

Debug Status Propagation

Layer / File(s) Summary
Debug status exposure and logging integration
cpp-linter/src/rest_client/mod.rs, cpp-linter/src/run.rs
RestClient gains an is_debug_enabled() method that delegates to the underlying client. The logging setup in run_main now uses an OR condition to enable Debug logging when either cli.general_options.verbosity.is_debug() or rest_api_client.is_debug_enabled() is true.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title mentions respecting verbosity per GitHub Actions env var, which directly aligns with the PR's objective of restoring behavior for the ACTIONS_STEP_DEBUG variable and the code changes that enable debug output when the REST API client detects this condition.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch gh-verbose-logs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.89%. Comparing base (45cfec0) to head (e61caef).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #346   +/-   ##
=======================================
  Coverage   92.88%   92.89%           
=======================================
  Files          22       22           
  Lines        3361     3364    +3     
=======================================
+ Hits         3122     3125    +3     
  Misses        239      239           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@2bndy5 2bndy5 merged commit 21b54d4 into main Jun 10, 2026
87 of 88 checks passed
@2bndy5 2bndy5 deleted the gh-verbose-logs branch June 10, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant