fix: do not fail on check for tool presence (via package managers)

[2bndy5]

• ref: Installing clang tools via apt fails in container #342

I added some debug logs and ran the clang-tools binary in a docker container. I found that the apt package manager support was failing because the check for any existing clang tool failed when the tool was not installed.

I converted the check for a clang tool's presence into a soft check. Meaning, if it somehow fails then just fall back to installing the clang tool as if doing a fresh/normal install.

Note

The container I used seemed to be too new; the LLVM install script does not yet support Ubuntu "resolute". But at least the clang-tools binary was able to fall back to static binaries. Plus, the debug and error logs are explanatory enough.

Summary by CodeRabbit

• Bug Fixes

  • Improved package installation reliability by gracefully handling detection failures and proceeding with installation attempts when needed.

• Chores

  • Enhanced diagnostic logging for package installation operations to aid troubleshooting.

[coderabbitai]

Walkthrough

This PR refines the native package installation flow in clang-tools-manager to handle version-check failures gracefully and improve diagnostic logging. When version verification fails (executable path unavailable or version capture unsuccessful), the installation now proceeds rather than erroring out immediately. Enhanced logging provides visibility into executed commands and apt installation failures.

Changes

Package installation flow improvements

Layer / File(s)	Summary
Fast-path version check error handling clang-tools-manager/src/downloader/native_packages/mod.rs	The "already installed" check in try_install_package now treats failures in get_exe_path() and capture_version() as non-matches using let Ok(...) guards instead of ? propagation, allowing the function to proceed to the installation attempt branch instead of returning an error.
Installation command logging and error diagnostics clang-tools-manager/src/downloader/native_packages/unix.rs	Debug logging is added before executing the package manager command, showing the full command with sudo prefix when applicable. Error-level logging is also added for failed apt installs with a specified version, capturing the package ID and decoded stderr for better troubleshooting.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• cpp-linter/cpp-linter-rs#279: Introduces the on-demand native package installation flow that this PR refines with improved error handling and logging in the version-matching and apt-install paths.

Suggested labels

bug, rust

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: converting the tool presence check from a hard error to a soft fallback mechanism, allowing installation to proceed when the check fails.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch debug-apt

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.88%. Comparing base (b213c8a) to head (e35dca3).

Files with missing lines	Patch %	Lines
...ols-manager/src/downloader/native_packages/unix.rs	62.50%	3 Missing ⚠️
...ools-manager/src/downloader/native_packages/mod.rs	71.42%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
+ Coverage   91.14%   92.88%   +1.74%     
==========================================
  Files          22       22              
  Lines        3354     3361       +7     
==========================================
+ Hits         3057     3122      +65     
+ Misses        297      239      -58     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.