Skip to content

fix: restore cargo binstall support#328

Merged
2bndy5 merged 2 commits into
mainfrom
fix-cargo-binstall
Jun 5, 2026
Merged

fix: restore cargo binstall support#328
2bndy5 merged 2 commits into
mainfrom
fix-cargo-binstall

Conversation

@2bndy5

@2bndy5 2bndy5 commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator
  • adjust suggested install command in README
  • ensure the binary executables are included in release assets (affected windows only)
  • adjust the custom pkg-url in Cargo.toml metadata for this monorepo's tag prefixes

I also changed the features of clang-installer since they were all related to the conditional bin feature.

Summary by CodeRabbit

  • Documentation

    • Updated README with revised installation instructions, including new guidance for Rust package installation.
  • Chores

    • Enhanced Windows artifact packaging process.
    • Refined build configuration and feature flags.

- adjust cmd suggested in README
- ensure the binary executables are included in release assets
- adjust the custom pkg-url in Cargo.toml metadata for monorepo's tag prefixes

I also changed the features of clang-installer since they were all related to the conditional bin feature
@2bndy5 2bndy5 added the bug Something isn't working label Jun 4, 2026
@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@2bndy5, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 9 minutes and 26 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5ed787a6-6d0b-40ad-95ea-4a6ac07d1951

📥 Commits

Reviewing files that changed from the base of the PR and between 0fe0f4f and 4c2e07c.

📒 Files selected for processing (1)
  • .github/workflows/bump-n-release.yml

Walkthrough

This PR refactors binary feature support by consolidating the clap feature into a unified bin feature with explicit dependencies, updates release distribution paths in binstall configuration, and documents these changes in README and CI workflows.

Changes

Binary Feature and Distribution

Layer / File(s) Summary
clang-installer feature consolidation
clang-installer/src/tool.rs, clang-installer/Cargo.toml
ClangTool's conditional clap::ValueEnum derive switches from the clap feature to the bin feature; the bin feature dependencies are rewritten to use dep:* form for dep:clap, dep:tokio, dep:anyhow, and dep:colored.
Release distribution configuration
cpp-linter/Cargo.toml
The binstall pkg-url template is updated to construct release download URLs under releases/download/cpp-linter/v{version}/... instead of the prior {name}/v{version}/... format, and clang-installer's binstall URL also follows the same new release path structure.
Documentation and CI updates
README.md, .github/workflows/binary-builds.yml
README text is rewrapped and the Rust installation command is updated to include --features bin; Windows artifact packaging tar commands are modified to use quoted arguments for the archive name, executable, and LICENSE file.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

enhancement

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: restore cargo binstall support' directly aligns with the PR's primary objective to restore cargo binstall support by updating pkg-url configurations, feature definitions, and binary packaging for Windows artifacts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-cargo-binstall

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]

This comment was marked as resolved.

for bump-n-release workflow
@codecov

codecov Bot commented Jun 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.94%. Comparing base (e88c348) to head (4c2e07c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #328   +/-   ##
=======================================
  Coverage   90.94%   90.94%           
=======================================
  Files          22       22           
  Lines        3368     3368           
=======================================
  Hits         3063     3063           
  Misses        305      305           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@2bndy5 2bndy5 merged commit d1f8d05 into main Jun 5, 2026
111 of 112 checks passed
@2bndy5 2bndy5 deleted the fix-cargo-binstall branch June 5, 2026 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant