Fix #76: -Wsign-conversion is redundant#149
Merged
lefticus merged 2 commits intocpp-best-practices:mainfrom Apr 15, 2026
Merged
Fix #76: -Wsign-conversion is redundant#149lefticus merged 2 commits intocpp-best-practices:mainfrom
lefticus merged 2 commits intocpp-best-practices:mainfrom
Conversation
…ANG_WARNINGS -Wconversion already implies -Wsign-conversion for both GCC and Clang, making the explicit -Wsign-conversion flag redundant in the CLANG_WARNINGS list. Since GCC_WARNINGS inherits from CLANG_WARNINGS, this removal applies to both compilers. Added a regression test to prevent reintroduction of the redundancy. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
=======================================
Coverage 20.50% 20.50%
=======================================
Files 5 5
Lines 239 239
Branches 111 113 +2
=======================================
Hits 49 49
+ Misses 186 184 -2
- Partials 4 6 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@leftibot remove the tests, those are unnecessary for this kind of PR |
Requested by @lefticus in PR cpp-best-practices#149 review. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Addressed review feedback from @lefticus. New commits: |
lefticus
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated fix by @leftibot.
What changed
Files
Closes #76
Triggered by @lefticus.