Skip to content

test: system tests for Fedora compatibility #81

Open
rmiki-dev wants to merge 1 commit intocontainers:mainfrom
rmiki-dev:fedora-system-tests
Open

test: system tests for Fedora compatibility #81
rmiki-dev wants to merge 1 commit intocontainers:mainfrom
rmiki-dev:fedora-system-tests

Conversation

@rmiki-dev
Copy link
Copy Markdown
Collaborator

This PR is a sub-issue of the initial System tests PR #78.

Due to cross-platform compatibility issues encountered in the original PR, I am splitting the implementation by platform. This specific PR focuses on stabilizing and enabling the system tests for Fedora builds.

Subsequent PRs will be submitted for macOS and Windows platforms/architectures once this baseline is merged.

Relates to #78

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the existing test suite by extracting common helper functions into a new tests/utils.sh file and significantly expands test coverage with several new integration scripts. These new tests cover various scenarios including delta paths, fuzzy renames, multiple old layers, source prefixes, and CLI error handling. Feedback highlights a potentially dangerous directory deletion in the Makefile, a bug in the sparse file creation logic within the utility script, and a portability improvement for temporary directory creation.

Comment thread Makefile Outdated
Comment thread tests/utils.sh Outdated
Comment thread tests/test-delta-paths.sh Outdated
@rmiki-dev rmiki-dev force-pushed the fedora-system-tests branch from 0b30b88 to 951b677 Compare April 15, 2026 15:47
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.60%. Comparing base (694288b) to head (88a378b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   68.94%   75.60%   +6.66%     
==========================================
  Files          10       10              
  Lines        1111     1111              
==========================================
+ Hits          766      840      +74     
+ Misses        232      159      -73     
+ Partials      113      112       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rmiki-dev rmiki-dev force-pushed the fedora-system-tests branch from 951b677 to 2b52a50 Compare April 15, 2026 18:10
Signed-off-by: Rosy-Glorious Miki <rmiki@redhat.com>
@rmiki-dev rmiki-dev force-pushed the fedora-system-tests branch from 2b52a50 to 88a378b Compare April 17, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant