Skip to content

Update for cuda-python 12.0.0 / CUDA 12. - #33

Merged
github-actions[bot] merged 34 commits into
conda-forge:mainfrom
bdice:cuda-12
Jun 2, 2023
Merged

Update for cuda-python 12.0.0 / CUDA 12.#33
github-actions[bot] merged 34 commits into
conda-forge:mainfrom
bdice:cuda-12

Conversation

@bdice

@bdice bdice commented Apr 5, 2023

Copy link
Copy Markdown
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Drafting this PR early (dependencies not yet ready). Resolves #31. Resolves #32 (replaces the autotick PR).

@conda-forge-webservices

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@bdice

bdice commented Apr 5, 2023

Copy link
Copy Markdown
Contributor Author

@conda-forge-admin, please rerender

@jakirkham

Copy link
Copy Markdown
Member

Think we need to add conda_build_config.yaml to the recipe to get the missing pieces

Do we want to do 12.0?

@bdice bdice changed the title Update for cuda-python 12.1.0 / CUDA 12. Update for cuda-python 12.0.0 / CUDA 12. Apr 20, 2023
@bdice

bdice commented Apr 20, 2023

Copy link
Copy Markdown
Contributor Author

@conda-forge-admin, please rerender

@bdice

bdice commented Apr 20, 2023

Copy link
Copy Markdown
Contributor Author

Think we need to add conda_build_config.yaml to the recipe to get the missing pieces

Do we want to do 12.0?

Yes and yes. I'm moving in this direction now! 😄

Comment thread recipe/meta.yaml Outdated
Comment thread recipe/meta.yaml Outdated
@bdice

bdice commented Jun 1, 2023

Copy link
Copy Markdown
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-webservices

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@bdice

bdice commented Jun 1, 2023

Copy link
Copy Markdown
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-webservices

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@bdice bdice mentioned this pull request Jun 2, 2023
5 tasks
@jakirkham
jakirkham requested a review from m3vaz June 2, 2023 20:54
@jakirkham

Copy link
Copy Markdown
Member

@conda-forge-admin, please re-render

@github-actions

github-actions Bot commented Jun 2, 2023

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/cuda-python-feedstock/actions/runs/5159664135.

@jakirkham
jakirkham dismissed m3vaz’s stale review June 2, 2023 20:58

Addressed in discussion, raised issues, & added a comment in the recipe

@jakirkham
jakirkham requested review from m3vaz and removed request for m3vaz June 2, 2023 20:59
Comment thread recipe/meta.yaml Outdated
Comment thread recipe/meta.yaml Outdated
@conda-forge-webservices

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • pin_subpackage should be used instead of pin_compatible for cuda-python because it is one of the known outputs of this recipe: ['cuda-python'].

@conda-forge-webservices

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
jakirkham requested a review from m3vaz June 2, 2023 21:12
@bdice

bdice commented Jun 2, 2023

Copy link
Copy Markdown
Contributor Author

@jakirkham @m3vaz I took a quick look here -- all the recent changes seem good to me (though I can't review my own PR).

@m3vaz m3vaz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakirkham jakirkham added the automerge Merge the PR when CI passes label Jun 2, 2023
@jakirkham

Copy link
Copy Markdown
Member

Thanks all! 🙏

Adding the automerge label so the bot will merge the PR once CI passes 🙂

@github-actions
github-actions Bot merged commit 8f1cd6b into conda-forge:main Jun 2, 2023
@github-actions

github-actions Bot commented Jun 2, 2023

Copy link
Copy Markdown
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@mmccarty

mmccarty commented Jun 2, 2023

Copy link
Copy Markdown
Contributor

Thanks all! Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Merge the PR when CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cuda-python: Support CUDA 12

5 participants