Remove Python 2 compatibility shims#34
Conversation
Python 2 compatibility was removed in conan-io#31 so these should not be useful / necessary anymore.
The CLI mode uses `sys` internally but has its own import.
It does almost nothing at this point and is only used by one caller, so can be inlined.
|
Thanks for your contribution, sorry it wasn't handled earlier. @uilianries maybe this change helps a bit with conan-io/conan#16727? |
|
Any update on this? I was meaning to add type hints to this, but the traces of Python2 in here is making things harder than it needs to be :) |
Signed-off-by: Uilian Ries <uilianr@jfrog.com>
Signed-off-by: Uilian Ries <uilianr@jfrog.com>
Signed-off-by: Uilian Ries <uilianr@jfrog.com>
|
I just fixed some minor mistakes using replace all in the code, and added a new test to validate when applying a 30MB patch file. |
Signed-off-by: Uilian Ries <uilianr@jfrog.com>
Signed-off-by: Uilian Ries <uilianr@jfrog.com>
Signed-off-by: Uilian Ries <uilianr@jfrog.com>
memsharded
left a comment
memsharded
left a comment
There was a problem hiding this comment.
Looks good, thanks for your contribution @xmo-odoo and @uilianries for reviewing and testing
|
@xmo-odoo Hello! Release 1.19.0 just arrived with your current PR! You can find its changelog at https://github.com/conan-io/python-patch-ng/releases/tag/1.19.0 Please, update your local version of Python Patch-NG and feel free to give us your feedback:
Regards! |
4 participants
Python 2 compatibility was removed in #31 so these should not be useful / necessary anymore.