feat: enhance parseRemoteAuthority to handle domains containing "--"#917
Open
ntoofu wants to merge 1 commit intocoder:mainfrom
Open
feat: enhance parseRemoteAuthority to handle domains containing "--"#917ntoofu wants to merge 1 commit intocoder:mainfrom
ntoofu wants to merge 1 commit intocoder:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As explained in CONTRIBUTING.md,
The parser splits on "--" to extract each component, but domain labels may contain "--".
In practice, IDNA/Punycode-encoded domain labels use
xn--as the ACE prefix.So the naive split("--") misparses hostnames with such labels, and causes errors like the following image.
For example, a Coder deployment
coder.xn--eckwd4c7cu47r2wf.jpwould produce an SSH host ofcoder-vscode.coder.xn--eckwd4c7cu47r2wf.jp--yourname--your-workspace.When split on "--", this yields
["coder-vscode.coder.xn", "eckwd4c7cu47r2wf.jp", "yourname", "your-workspace"]but the parser expects the first element to be the full hostname, so vscode-coder would try to open a workspaceyournamewhose owner iseckwd4c7cu47r2wf.jpand fails.Solution
Added a reassembly step after the initial split("--").
The algorithm scans from the front of the split result:
This works because Coder usernames never contain dots,
so any dot-bearing segment after the split must be a hostname fragment.
Note: a TLD containing "--" would not be handled correctly because such hostname would fragment into segments the last of which does not contain dot, but no such TLD exists today.