Draft
Conversation
Adds a `make fmt` target that runs `gofmt -w .` and a matching `fmt` job in the existing Lint workflow. The job runs `make fmt` and fails via the existing `scripts/check_unstaged.sh` when any Go file is not formatted. Generated with Coder Agents.
Result of running the newly added `make fmt` against the tree. Generated with Coder Agents.
zedkipp
force-pushed
the
zedkipp/ci-go-fmt
branch
from
ae10665 to
1d162cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a formatting check to CI that fails when any Go file is not
gofmt-clean.Nothing in CI catches unformatted Go today:
.github/workflows/lint.ymlinstallsgolangci-lintbut never runs it. This change adds afmtjob to the same workflow that runsmake fmtand uses the existingscripts/check_unstaged.shto fail on any diff.types/diagnostics_test.gowas already notgofmt-clean onmain; that reformat is included as a separate commit.Generated with Coder Agents.