Repository navigation
Initializr: random per-download id for default-package projects - #6067
Conversation
…lt package
The funnel keys an Initializr download, its launcher runs and its IDE builds
by SHA-256 of the package name. Most downloads keep com.example.myapp, so
they all shared one subject (f110a249) and could not be told apart -- 9 of 13
downloads in one window were that hash. Such a download now gets a random id,
made once and used everywhere the hash was (launchers, pom/gradle telemetry
opt-in, the download beacon and the steps request); the page sends it as is
('id:<64 hex>' from GeneratorModel#beaconKey). Any other package is unchanged,
so its download still joins its first cloud build by package. BuildCloud
already accepts any 64-hex subject: no server change.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fbf596ecdf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…om source java.util.Random on the JavaScript port is seeded from the clock alone, so two browsers generating a project in the same millisecond got the same id. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Cloudflare Preview
|
1 participant
Funnel subjects are SHA-256(package). Most Initializr downloads keep com.example.myapp, so they all merged into one subject (f110a249): 9 of 13 downloads in a recent window. Default-package downloads now get a random 64-hex id used everywhere the hash was (launchers, pom/gradle opt-in, download beacon, steps request); the page sends it as is (
id:<hex>). Other packages unchanged, so their cloud-build join by package still works. No BuildCloud change: the server accepts any 64-hex subject.Tests: Initializr cn1:test 8/8 (matrix test updated: stable per download, distinct across downloads, not the shared hash); beacon test adds the id form; bridge test passes.
🤖 Generated with Claude Code