Repository navigation
Update the bundled BuildClient to the resumable sign-in build - #6063
Merged
Merged
Conversation
Rebuilt from codenameone/BuildClient master at 50f794c (BuildClient #8) with JDK 8 and that worktree's own maven repo; the 29 client tests pass. Java 7 bytecode as before. The entry list differs from the one it replaces by exactly the classes the change adds: BrowserLoginPoller$NotFinishedException, BrowserLoginPoller$PeerLogin, and CodeNameOneBuildTask$LoginWait (replacing the anonymous CodeNameOneBuildTask$4). What it changes for a developer: re-running a build after the sign-in wait ended continues the same sign-in instead of starting a new one, so a sign-in finished late in the browser (a registration, a slow Google consent, a Ctrl+C) is collected. Most stalled build-tool sign-ins in production were re-runs that started over. This covers only the bundled copy. Existing installs update through UpdateCodenameOne.jar, which compares CodeNameOneBuildClientJar in https://www.codenameone.com/files/updates/UpdateStatus.properties (currently 209) by string equality, so the hosted jar must be replaced and that key bumped to 210 on download.codenameone.com, or nobody re-downloads. sha256 2792a0ef5311866f0b312419d185f83112ea7771325fd1442e32806e9d9e654a Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuilt from codenameone/BuildClient master 50f794c (BuildClient #8), JDK 8, 29 client tests pass, Java 7 bytecode. Entry list differs only by the classes #8 adds.
Re-running a build after the sign-in wait ended now continues the same sign-in instead of starting over.
Existing installs update from download.codenameone.com: replace files/updates/CodeNameOneBuildClient.jar with this jar and bump CodeNameOneBuildClientJar in UpdateStatus.properties from 209 to 210, or nobody re-downloads.
sha256 2792a0ef5311866f0b312419d185f83112ea7771325fd1442e32806e9d9e654a
🤖 Generated with Claude Code