refactor: Model#8260
Merged
Merged
Conversation
kenjis
force-pushed
the
refactor-model
branch
from
November 27, 2023 23:38
122f73b to
3ca0768
Compare
kenjis
marked this pull request as draft
November 27, 2023 23:58
kenjis
marked this pull request as ready for review
November 28, 2023 00:37
michalsn
reviewed
Nov 28, 2023
michalsn
left a comment
Member
There was a problem hiding this comment.
I'm not sure about changes that restrict the use of certain methods to the Entity class only.
kenjis
force-pushed
the
refactor-model
branch
from
November 28, 2023 21:41
7eb9b96 to
9745bac
Compare
5 tasks
kenjis
marked this pull request as draft
November 30, 2023 07:30
kenjis
force-pushed
the
refactor-model
branch
2 times, most recently
from
December 7, 2023 00:06
ec520ac to
4bfa67c
Compare
kenjis
force-pushed
the
refactor-model
branch
from
December 7, 2023 00:13
4bfa67c to
7ad3c38
Compare
kenjis
marked this pull request as ready for review
December 7, 2023 00:33
Member
Author
|
The PHPStan errors are not related to this PR. https://github.com/codeigniter4/CodeIgniter4/actions/runs/7121907724/job/19392022128?pr=8260 Created an issue #8300 |
michalsn
approved these changes
Dec 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist: