Skip to content

test: fix the testcase error on MariaDB. #7989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenjis merged 2 commits into from
Oct 1, 2023
Merged

test: fix the testcase error on MariaDB. #7989

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5e62f9
fix: fix the testcase error on mariaDB.
ping-yee Sep 28, 2023
72825b2
test: change `strpos` function to search the string.
ping-yee Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/system/Database/Live/ForgeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,7 +941,7 @@ public function testAddFields(): void
],
];

if (version_compare($this->db->getVersion(), '8.0.17', '>=')) {
if (version_compare($this->db->getVersion(), '8.0.17', '>=') && strpos($this->db->getVersion(), 'MariaDB') === false) {
// As of MySQL 8.0.17, the display width attribute for integer data types
// is deprecated and is not reported back anymore.
// @see https://dev.mysql.com/doc/refman/8.0/en/numeric-type-attributes.html
Expand Down