multiple File upload issue

upload of multiple files returns null

below is what i tried
<input accept="image/*" multiple type="file" id="feed-editor-image-input" name="images[]"/>
$imagesFile = $this->request->getFiles('images'); var_dump($imagesFile);

@chistel

@chistel In the function getFiles() on line 487 of the IncomingRequest class, if you change

public function getFiles(): FileCollection
{
	if (is_null($this->files))
	{
		$this->files = new FileCollection();
	}
	return $this->files;
}

to

public function getFiles()
{
	if (is_null($this->files))
	{
		$this->files = new FileCollection();
	}
	return $this->files->all();
}

It will work for now. I would let @lonnieezell check over this though because it is a dead end with getFiles().

@chistel

A couple of thoughts for you @chistel:

Is your form setup with enctype=multipart/form-data? Forgetting that is a common error, for me anyway.
Did you dump the $_FILES variable to ensure there was anything actually uploaded that the server recognized?
You're calling getFiles('images), however that method simply returns all files within a FileCollection class (and, yes, @JakeAi that's the way it should be. The FileCollection class provides some handy helper functions you might want to use.). To retrieve a single file, you should use the getFile() method (singular). Or use getFiles() and then you can do checks like hasFile(), etc.
Finally, when trying to access a single file of an array of files like you have here, you should use dot array syntax.

@JakeAi

@JakeAi That was my first solution, but it returned error say Hercules must be an instance of FileCollection except I have to remove the instance from it

@lonnieezell

@lonnieezell pls can you give a sample of running a multi file upload to a folder using the getFiles() method

@chistel

@chistel I might be able to pull something together tonight (just getting my morning started here), but you never answered the questions - especially #1 and #2.

@lonnieezell

@lonnieezell Oh skip me, #1 & #2 did that, and 3 I figured that I was on the wrong path.
Now it's returns all. but it would be better using specific field name than just returning all uploaded file. Especially if I have two different file field in a single form

@lonnieezell

@lonnieezell I couldn't even get getFiles to work without modifications. getFiles creates a new FileCollection class, but there is no construct and doesn't call any functions?, and this->files is null. If you call getFile('w/e') and then getFiles, it works.

 <form action="/Shared/Test" method="post" enctype="multipart/form-data">
        <input multiple type="file" id="feed-editor-image-input" name="images[]"/>
        <input type="submit">
    </form>

// This doesn't work
	print_r( [
			$_FILES,
			$this->request->getFiles(),
		] );

Array
(
    [0] => Array
        (
            [images] => Array
                (
                    [name] => Array
                        (
                            [0] => 170586-Subaru_Impreza_WRX-Subaru_Impreza-Subaru-JDM.png
                            [1] => 17499755_1403719142999697_1454939783_o.jpg
                        )

                    [type] => Array
                        (
                            [0] => 
                            [1] => image/jpeg
                        )

                    [tmp_name] => Array
                        (
                            [0] => 
                            [1] => D:\Wamp\tmp\php6315.tmp
                        )

                    [error] => Array
                        (
                            [0] => 1
                            [1] => 0
                        )

                    [size] => Array
                        (
                            [0] => 0
                            [1] => 118352
                        )

                )

        )

    [1] => CodeIgniter\HTTP\Files\FileCollection Object
        (
            [files:protected] => 
        )

)

// This works
	print_r( [
			$_FILES,
			$this->request->getFile( 'images' ),
			$this->request->getFiles(),
		] );

@JakeAi

@JakeAi I figured it out in to ways, either add the all method of FileCollection into a constructor or go with the previous method you suggested but removing the fileCollection instance from getFiles() method

@lonnieezell

@lonnieezell Never mind about my last response and request, I figured it out. I would make a doc regarding it.

@chistel

@chistel All you need to do is return all() and remove the return type after getFiles(). You don't need to necessarily remove the instance.

public function getFiles(): FileCollection // <-----
{
	if (is_null($this->files))
	{
		$this->files = new FileCollection();
	}
	return $this->files; // <-----
}

to

public function getFiles() // <-----
{
	if (is_null($this->files))
	{
		$this->files = new FileCollection();
	}
	return $this->files->all(); // <-----
}

@JakeAi

@JakeAi exactly what I did

@chistel

@chistel Oh, right on. I'm still confused though. Is @lonnieezell right? Or is something broken? Like, I understand about the helper functions, but I couldn't get it to work at all. populateFiles doesn't get called at all through getFiles(). Are you supposed to $files=getFiles() then $files->getFile()? I feel like it's an inconvenience. I'd like to get files and then foreach the files and call the helpers on those iterations?

@JakeAi

@JakeAi he is right, I can't find anything broken there.. when I make the doc, I would clarify it

@chistel

@chistel Can you post your sample code?

@JakeAi

@JakeAi am on mobile now, but here is what I have,

If($imagefile = $this->request->getFiles())
{  
   foreach($imagefile['images'] as $Im)
   {
      if ($im->isValid() && ! $im->hasMoved())
      {
           $newName = $img->getRandomName();
           $img->move(WRITEPATH.'uploads', $newName);
      }
   }
}

where the images is the form field name
<input type="file" name="images[]" multiple />

@chistel

@chistel did you add the all() to the IncomingRequest then? Because your code doesn't work out of the box.

@JakeAi

@JakeAi yes I added it

@chistel

@chistel Ahhh, that's what I meant about being broken. So something does need changed.

@JakeAi

@JakeAi 🙄🙄🙄 yes just that

@chistel

@chistel 's changes have been merged in, so closing this.

Navigation Menu

Repository navigation

multiple File upload issue #679

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

multiple File upload issue #679

Description

Activity

JakeAi commented on Aug 16, 2017

lonnieezell commented on Aug 16, 2017

Iamscalla commented on Aug 16, 2017

Iamscalla commented on Aug 16, 2017

lonnieezell commented on Aug 16, 2017

Iamscalla commented on Aug 16, 2017

JakeAi commented on Aug 16, 2017

Iamscalla commented on Aug 16, 2017

Iamscalla commented on Aug 16, 2017

JakeAi commented on Aug 16, 2017

Iamscalla commented on Aug 16, 2017

JakeAi commented on Aug 16, 2017

Iamscalla commented on Aug 16, 2017

JakeAi commented on Aug 16, 2017

Iamscalla commented on Aug 16, 2017

JakeAi commented on Aug 16, 2017

Iamscalla commented on Aug 16, 2017

JakeAi commented on Aug 16, 2017

Iamscalla commented on Aug 16, 2017

lonnieezell commented on Aug 17, 2017

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions