Skip to content

Do not exclude ".gitignore" and ".cvsignore" by default#326

Merged
kwin merged 1 commit intomasterfrom
feature/remove-gitignore-cvsignore-from-defaultexcludes
Apr 1, 2026
Merged

Do not exclude ".gitignore" and ".cvsignore" by default#326
kwin merged 1 commit intomasterfrom
feature/remove-gitignore-cvsignore-from-defaultexcludes

Conversation

@kwin
Copy link
Copy Markdown
Contributor

@kwin kwin commented Mar 30, 2026

This closes #312

@kwin kwin requested review from gnodet and slawekjaranowski March 30, 2026 16:41
Copy link
Copy Markdown
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is ok
but we should mark change as breaking

@slawekjaranowski
Copy link
Copy Markdown
Member

also do it the same on 3.x branch

@kwin kwin added the breaking label Mar 30, 2026
@kwin
Copy link
Copy Markdown
Contributor Author

kwin commented Mar 31, 2026

also do it the same on 3.x branch

3.x does not contain .gitignore in excludes anyhow in that branch, only .csvignore needs to be done there.

@kwin kwin merged commit e9f14be into master Apr 1, 2026
14 checks passed
@kwin kwin deleted the feature/remove-gitignore-cvsignore-from-defaultexcludes branch April 1, 2026 09:46
kwin added a commit that referenced this pull request Apr 1, 2026
kwin added a commit that referenced this pull request Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AbstractScanner.DEFAULT_EXCLUDES must not include ".gitignore" or ".cvsignore"

2 participants