Fix for stepByStepReport: cheerio ESM import and missing screenshot capture#5508
Open
gololdf1sh wants to merge 1 commit intocodeceptjs:4.xfrom
Open
Fix for stepByStepReport: cheerio ESM import and missing screenshot capture#5508gololdf1sh wants to merge 1 commit intocodeceptjs:4.xfrom
gololdf1sh wants to merge 1 commit intocodeceptjs:4.xfrom
Conversation
Author
EvidenceBug 1: Plugin crashes on load (cheerio ESM import)Before fix — Bug 2: Screenshots never captured (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two bugs in
stepByStepReportplugin that made it completely non-functional in v4.x (ESM):import cheerio from 'cheerio'fails because cheerio 1.x removed the default export. Changed toimport * as cheerio from 'cheerio'if (!step.test) returninpersistStep()always returned early becausestep.testproperty doesn't exist on theStepclass. Replaced withif (!currentTest) returnwhich correctly checks the plugin's existingcurrentTestvariableHow it was tested
{ enabled: true, deleteSuccessful: false }Relates to #5351