简化了一下SeleniumDownloader的结构#624
Open
darknt wants to merge 2 commits intocode4craft:masterfrom
Open
Conversation
获得webDriver时先判断是否设置了远程url,之后设置DesiredCapabilities,使用remote driver时如果selenium server上没配置好某浏览器,那么driver的capabilities就不能为该浏览器
Author
|
好吧,我不是搞java的,现在才知道测试里面的@ignore时干嘛的,麻烦看看吧,有用就合并一点.从这个项目中受益良多所以想有点贡献,本来用的git.oschina.net,特意来fork的 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
selenium不方便切换代理,所以使用一个代理绑定一个webDriver的方式处理
获得webDriver时先判断是否设置了远程url,之后设置DesiredCapabilities,使用remote driver时如果selenium server上没配置好某浏览器,那么driver的capabilities就不能为该浏览器