Skip to content

[pull] main from TryGhost:main - #1524

Merged
pull[bot] merged 21 commits into
code:mainfrom
TryGhost:main
Sep 28, 2026
Merged

pull[bot] merged 21 commits into
code:mainfrom
TryGhost:main

Conversation

@pull

@pull pull Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

9larsons and others added 21 commits September 28, 2026 11:05
no ref

In dev, opening any modal Radix surface in Safari (the sidebar user
menu, the posts sort menu, the posts right-click menu) blocks the main
thread for about two seconds.

Radix calls `aria-hidden`'s `hideOthers` from an effect. StrictMode
replays that effect as set, undo, set in one task, and in WebKit the
undo that follows the set takes ~1.8s while the window is visible.
Popovers, including the posts filter, are non-modal and never call it.

This patches `aria-hidden` to apply its attributes in a microtask, so an
undo in the same task cancels them instead of toggling `aria-hidden`
across the whole page. The apply is skipped if the content has already
been removed from the page by then. Menus stay modal and StrictMode
stays on.

The same code runs in production, where nothing replays the effect. The
only difference there is that `aria-hidden` lands one microtask later,
still before the next paint.
…ey (#31006)

no ref

Shifted some test coverage around between acceptance and e2e to be more appropriate.
…st (#30989)

no ref

Small patch to an ordering bug (albeit a bit of an edge case).
Header tooltips behaved inconsistently across Admin pages, and several
controls still had incorrect pill shapes, hover/pressed colors,
variants, or spacing. This PR centralizes header tooltip timing in Shade
and addresses the 13 refinements in
[DES-1534](https://linear.app/ghost/issue/DES-1534/refine-pill-style),
each in its own commit.

Reusable changes live in Shade: filter-bar hover treatments,
image-overlay pressed/open colors, pill-shaped button tabs, header
dropdown icon spacing, and an optional header-select tooltip. Settings
modal headers and tier benefit controls reuse existing Shade header
actions and input-group buttons. Screen-specific button roles, the
Unsplash logo, and tooltip wording remain local.

All updated behavior is behind `admin7Pill`, consumed through Shade's
existing `isAdmin7` context. Flag-off styling and behavior are
preserved.

Validation:
- Shade build, lint, type checks, and all 283 unit tests passed.
- Admin type checking and targeted acceptance suites passed for
Analytics, Members headers, the Admin 7 rollout boundary, staff, tiers,
Design, Theme, Announcement, Portal, and newsletters. Automation editor
unit tests also passed.
- Manual checks covered filter hover contrast, Analytics spacing and
date tooltip removal, pill tabs, the Unsplash action, image-overlay
states, and compact tier controls.
- Independent subagent review found no actionable issues or flag-off
leaks. No visual regression tests were added for these refinements; the
earlier tooltip fix includes focused interaction tests. Native OS window
switching still needs a manual smoke test.

- [x] I've read and followed the Contributor Guide
- [x] I've explained my change
- [x] I've written an automated test to prove my change works
ref https://linear.app/ghost/issue/HKG-1973

Automation initialization can schedule analytics immediately. The newsletter
jobs migration needs handlers and backend startup after executor dependencies
but before polling, mounting, and background recovery.
ref https://linear.app/ghost/issue/HKG-1974

Every other schedule in initBackgroundServices runs before activitypub.init
so an activitypub failure cannot leave it unscheduled for the life of the
process, and the comments say so. The analytics block was the one left
after it. Slide it up with its siblings.
The Tinybird scripts README
(`ghost/core/core/server/data/tinybird/scripts/README.md`) has two wrong
commands:

- The Docker workflow runs `pnpm docker:reset:data`, which isn't a
script in the root `package.json`, so step 2 fails with "Command not
found".
- The note says to use `pnpm reset:data` when running Ghost without
Docker, but that script is `docker exec ghost-dev ...`, so it only works
with the Docker environment up.

This changes step 2 to `pnpm reset:data` and replaces the note with the
fact that it needs the `ghost-dev` container. Docs only, outside the
publishable packages, so no changeset.
no ref

This is a test-only change.
Fix saved post views losing their filters on refresh, and align the post
list controls with the existing members and analytics UI.

On refresh, the Ember-to-React handoff briefly wrote a queryless URL,
then silently restored it. React could initialize in between and retain
the default list despite the restored query parameters. The handoff now
suppresses URL writes entirely, preserving filters, sorting, sidebar
saved-view selection, and React Router history state for both posts and
pages.

The React post list's edit-view actions differed from the members list
and deleted saved views immediately. Align the dialogs with small
Delete, Cancel, and Save buttons, plus a cancellable “Delete view?”
confirmation before deletion. The create-view Save button also uses the
small size.

The confirmation uses an outlined Cancel button and a filled red Delete
button. Cancel returns to editing with unsaved changes preserved;
confirmed deletion shows a pending state, then closes the popover and
returns to the post list. Failed deletions stay open for retrying.

The sorting dropdown also uses the same Shade Select as the analytics
period dropdown, with a trailing checkmark for the selected order.

ref https://linear.app/ghost/issue/PLA-457/post-list-refinements

Post row action titles and accessible labels are now “Edit” and “Post
analytics”.

Validation:
- All 4 post-row action-button acceptance tests passed with the updated
labels.
- Refresh regression: reproduced in local Admin before the fix, then
verified single-filter and multi-filter saved views load correctly and
remain selected in navigation after refresh.
- All 16 Ember handoff acceptance tests and 3 route unit tests passed.
The two new posts/pages regressions failed before the fix on queryless
URL writes and passed afterward.
- Focused ESLint and formatting checks passed.
- All 5 existing sorting browser acceptance tests passed, covering the
default label, URL-derived label, changing order, restoring the default,
and preserving filters. Visually verified the trailing checkmark and
checked keyboard selection in local Admin.
- 39 tests passed across the popover and saved-view suites, including
four new tests covering confirmation, cancellation, reopening, pending
requests, and failed-deletion retries.
- Visually verified both action states in local Admin and checked
cancellation behavior.
- Earlier `pnpm check`: formatting and lint passed. The full test run
reported 3 failures in unrelated Admin country-filter/theme-archive
tests and 44 failures in Ghost Core tests (including timeouts). Stopped
the remaining Koenig acceptance run after these failures. The
confirmation follow-up was validated with the focused checks above.

Cropped screenshots were captured locally; GitHub attachment upload was
blocked by the browser extension file-access setting.
no ref

Bumps pnpm to 12.7.0 and deduplicates the lockfile, collapsing
compatible duplicate versions that had accumulated (AWS SDK, Smithy,
typescript-eslint, browserslist and friends). ember-admin's exact
`semver: 7.7.4` pin also moves to the catalog (7.8.5), dropping another
duplicate.

12.7.0 rather than 12.6.0: 12.6.0 runs package scripts in their own
process group, so when Playwright's `webServer` teardown SIGKILLs pnpm's
process group, the script (e.g. `vite preview`) survives and holds
Playwright's output pipes open, hanging the App Playwright Acceptance
Tests jobs. 12.7.0 fixes this
([pnpm/pnpm#15555](pnpm/pnpm#15555)).

pnpm's new `autoDedupe` setting would keep the lockfile deduplicated on
every install, but it is left off for now. With it enabled, the
`verifyDepsBeforeRun` check fails on every `pnpm run` and `pnpm exec`
(12.6.0 and 12.7.0), so each command runs a full install first, even
straight after one. In CI, the e2e Playwright container ran that install
as root, leaving a root-owned `node_modules` that the host's
`infra:down` step then could not replace. Note that 12.7.0's `pnpm
dedupe` also moves transitive dependencies down to versions pinned
directly anywhere in the workspace (e.g. `@typescript-eslint/types` 8.67
→ 8.56, `@types/chai` 5 → 4), so review its diff rather than running it
blindly.

Also fixes a latent CI issue this lockfile change exposed. The unit,
legacy and acceptance jobs install with `--no-runtime` so each matrix
leg runs its own Node, but pnpm keys cached native builds by the
`devEngines` Node major (node22) regardless. Because those legs share
one pnpm store cache, the Node 24 unit job reused a `better-sqlite3`
build compiled for Node 22 and failed with a `NODE_MODULE_VERSION`
mismatch. Which leg wins depends on which job saves the store cache
first for a new lockfile, so this could hit `main` too (reproduced with
pnpm 12.4.2). These installs now pass
`--config.side-effects-cache=false`, so native modules build for the
running Node.
no ref

Importing a post with an empty mobiledoc and `lexical: null` fails with:

```
ERROR [Background Job] site-content-import error Invalid lexical structure.
```

Regressed in #28906 (first shipped in v6.51.0). The importer used to
render mobiledoc to HTML itself. The Post model now converts the
mobiledoc to lexical on save. An empty mobiledoc, such as a Ghost 3.0
post with `"sections":[]`, converts to a lexical document with an empty
root. The lexical renderer rejects an empty root (Lexical error #38), so
the post is dropped from the import.

The fix swaps in the model's existing `lexicalLib.blankDocument` only
when the source mobiledoc has no sections. A mobiledoc whose sections
are all unsupported (e.g. type-2 image sections, which the converter
drops) still fails validation rather than being silently blanked. This
isn't database-specific; the added integration test fails on MySQL
without the fix.
ref https://linear.app/ghost/issue/HKG-1973

The newsletter pipeline was the first analytics job still running through
the legacy Bree worker, which had to rebuild its own dependencies in a
thread and could only signal the main process through a domain event.
Running the tick in-process on JobsService lets it call the initialized
wrapper directly, in its own two-slot queue so an overlapping tick reaches
the wrapper's fetch guard instead of queueing behind the running fetch.

Registration is now asynchronous, so the scheduler marks a pipeline
scheduled before awaiting the backend and unmarks it on rejection, keeping
concurrent callers from registering a second schedule with a different
cron. Boot settles the three schedules and logs each failure like its
sibling background jobs, so a rejected registration can no longer skip the
remaining background services or hide a sibling's failure.
ref https://linear.app/ghost/issue/HKG-1974

Same transport swap as the newsletter pipeline, for the same reasons: the
automation tick now runs in-process against its initialized wrapper in its
own two-slot queue, so the worker bridge and start event for this pipeline
can go. Automation cursor names and the polling bypass are unchanged so
existing cursors keep working after the upgrade.
ref https://linear.app/ghost/issue/HKG-1974

Gift ticks were the last email analytics pipeline still bridged through the
legacy Bree worker. Running them in-process on their own two-slot queue keeps
overlapping ticks flowing into the wrapper's fetch guard, matches the
newsletter and automation pipelines, and lets the worker bridge and the
scheduler's job manager dependency be removed.
ref https://linear.app/ghost/issue/HKG-1974

When a pass hit its event ceiling the wrapper restarted itself without
returning the promise, so the JobsService handler resolved after the first
pass while the continuation kept fetching. That logged a false completion
with a truncated duration and left the continuation outside the shutdown
drain, where a restart tore knex down under it. Returning the continuation
makes one tick span the whole run.
ref https://x.com/trq212/status/2101009392611278961

This change should have no user impact.

Claude Code 2.1.277+ [now respects `AGENTS.md`][0]. Let's use it.

[0]: https://x.com/trq212/status/2101009392611278961
no ref

Moves the admin accent colour variables from Ember to React and removes Ember's handling entirely. No feature flag: the output is the same variables with the same values, and Ember keeps nothing to fall back to.
Enable Shade's default pill styles in standalone ActivityPub and refine
the Social Web controls: navigation uses the Admin sidebar radius,
Reader toolbar actions share rounded corners, Notes ellipsis triggers
are circular, and popover items use Shade's standard menu-item radius.
Embedded ActivityPub continues to inherit the Admin application's design
setting.

Give profile covers 8px spacing above and beside the sidebars, with
corners matching the Admin sidebar. Expand the embedded ActivityPub
layout to a 1920px maximum so the right sidebar reaches the viewport
edge on laptop and desktop screens, while profile text and posts retain
their readable width.

Validation:
- ActivityPub typecheck and all 135 unit tests passed.
- All 28 selected feed, profile, and preferences browser tests passed.
- Reviewed the notes feed and composer at desktop and mobile widths with
the shared Admin stylesheet loaded; confirmed the portaled composer
inherits the pill design. The standalone acceptance harness does not
load that stylesheet itself.
- Follow-up refinements: visually checked navigation, Reader actions,
and the Notes delete menu; confirmed the delete-flow browser test,
focused lint/format checks, Admin build, and commit hooks pass.
- Profile layout: visually checked mobile, laptop, and wide desktop
layouts; ActivityPub typecheck, focused lint/format checks, and commit
hooks passed. The Admin bundle compiled, but its final asset-copy step
hit a local ActivityPub dist symlink conflict.
- Formatting and repository lint passed for the initial rollout change.
- `pnpm check` did not pass: untouched Ghost Core tests reported 17
failures (mostly timeouts, plus scheduling and email assertions), and an
Admin custom-field filter test timed out. Stopped the remaining broader
run after those failures.

Checklist:
- [x] I've read and followed the Contributor Guide.
- [x] I've explained my change.
- [ ] I've written an automated test to prove my change works — reused
existing coverage and visual review for this provider-default change.
no ref

The React editor's publish flow had ports for the host's sending and publishing checks, but nothing supplied them, so a site could publish over its members limit, and send over its monthly email limit or under an email verification hold.

The header now builds the ports (`usePublishLimits`) from the framework's limiter and the editor's settings.
…#31015)

ref https://linear.app/ghost/issue/NY-1630
ref https://linear.app/ghost/issue/NY-1633

Some users were hitting `GET /automations` with the labs flag disabled.
This caused welcome emails to break.

I think these users were doing something they shouldn't have, but we can
tighten things a bit to prevent this from happening.
@pull pull Bot locked and limited conversation to collaborators Sep 28, 2026
@pull pull Bot added the ⤵️ pull label Sep 28, 2026
@pull
pull Bot merged commit 1960eda into code:main Sep 28, 2026
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants