[claudiacodacy]

Why

Every chart PR off master currently fails install-k8s-unstable: the bundled MinIO pod never becomes ready, Helm hits its 20m timeout and rolls back. Cause: the minio 5.0.33 subchart pins minio/minio:RELEASE.2020-06-14T18-32-17Z and minio/mc:RELEASE.2020-05-28T23-43-36Z, and MinIO's public images are no longer pullable from Docker Hub or Quay. install-k8s-unstable is a required check, so nothing can merge to master until this is fixed (e.g. #847).

release-17.0.0 (#833) already fixes this by switching to RustFS, and its installs pass on k8s 1.30–1.33. #833 is held up by its QA suites, so this PR takes only the object-store swap and lands it on master on its own.

What

Cherry-picked from release-17.0.0 (authorship kept, -x trailers point to the originals):

• ce0c597 Replace MinIO with RustFS as the bundled object store
• 92920b5 Register the rustfs Helm repo in setup_helm_repos
• 942faec Upgrade the helm-push plugin to v0.10.4 / cm-push (the old plugin can't push a v1 chart that has a v2 subchart)
• 7551652 Replace the old built-in Helm in the .do deploy jobs

Left out on purpose:

• codacy/requirements.lock: master removed it in fix: Remove requirements.lock before building #393.
• docs/ changes: chore: move the files the Self-hosted docs link to out of docs/ [OD-1040] #847 moves those docs to codacy/docs, where the MinIO → RustFS wording needs a follow-up.
• The chart-museum DELETE of an existing version in the push step, which comes from a different release-branch commit.
• The other release changes (rabbitmq tag, worker image version, timeouts, resources, fluentd lifecycle job).

Checked locally (Helm v3.19.0)

• helm dep build resolves rustfs-1.0.3; helm lint passes.
• helm template with values.yaml, values-production.yaml and values-microk8s.yaml: no MinIO resources; RustFS Deployment, Service (codacy-rustfs-svc), PVCs, Secret and bucket Job render, and global.minio.location resolves to codacy-rustfs-svc.
• rustfs/rustfs:1.0.3, amazon/aws-cli:2.17.0 and busybox:stable all pull from Docker Hub.

CI on this PR is the real install check.

For reviewers

• Upgrades: existing installs keep their data on the codacy-minio PVC. This PR doesn't move that data to RustFS. That's the same as release: prepare 17.0.0 #833, but on master it reaches unstable sooner.
• extract-codacy-logs.sh still targets MinIO's pod label and paths (noted in ce0c597).

🤖 Generated with Claude Code

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

_{TIP This summary will be updated as you push new changes.}

[codacy-production]

Pull Request Overview

⚠️ Resolve issues before merging

Committed object-store credentials must be removed before merging. The chart should obtain them from Kubernetes Secrets or installation-time values and reuse one source for all consumers. Core dependency, rendering, installation, lifecycle, and publishing scenarios are not covered by the submitted changes and should be validated.

Test suggestions

• Build dependencies and lint/render the chart using the default, production, and microk8s values files.
• Verify the rendered chart contains RustFS resources and no MinIO workload resources, with consumers pointing to the RustFS service.
• Install or upgrade the chart and verify RustFS becomes ready, buckets are created, and lifecycle configuration is applied.
• Verify the deployment path upgrades Helm before installing local or chart-museum releases.
• Verify chart publishing installs the modern plugin and successfully pushes a v1 parent chart containing the RustFS v2 dependency.
• Verify Fluentd can write logs to the RustFS S3-compatible endpoint using path-style addressing.

Prompt proposal for missing tests

Consider implementing these tests if applicable:
1. Build dependencies and lint/render the chart using the default, production, and microk8s values files.
2. Verify the rendered chart contains RustFS resources and no MinIO workload resources, with consumers pointing to the RustFS service.
3. Install or upgrade the chart and verify RustFS becomes ready, buckets are created, and lifecycle configuration is applied.
4. Verify the deployment path upgrades Helm before installing local or chart-museum releases.
5. Verify chart publishing installs the modern plugin and successfully pushes a v1 parent chart containing the RustFS v2 dependency.
6. Verify Fluentd can write logs to the RustFS S3-compatible endpoint using path-style addressing.

Low confidence findings

• Document and validate the upgrade behavior for existing MinIO data, since replacing the backend may leave prior data inaccessible and start RustFS with an empty store.

_{TIP How was this review? Give us feedback}