fix: to_json breaking change#191
Merged
xSAVIKx merged 7 commits intoAug 25, 2022
Merged
Conversation
Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
for more information, see https://pre-commit.ci
Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
for more information, see https://pre-commit.ci
xSAVIKx
reviewed
Aug 23, 2022
Member
xSAVIKx
left a comment
xSAVIKx
left a comment
There was a problem hiding this comment.
Thx for taking care of this. Please bump the version of the module and also add the respective section in the changelog
| @@ -5,6 +5,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## [Unreleased] | |||
Member
There was a problem hiding this comment.
Please add the 1.6.1 release section and also update the version in the module init.py
Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
Signed-off-by: Alexander Tkachev <sasha64sasha@gmail.com>
xSAVIKx
approved these changes
Aug 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #190
Changes
Add missing
to_jsonimportOne line description for the changelog