Skip to content

Update lxml to 6.1.0#1142

Merged
marcospri merged 1 commit into
masterfrom
update-lxml
May 14, 2026
Merged

Update lxml to 6.1.0#1142
marcospri merged 1 commit into
masterfrom
update-lxml

Conversation

@marcospri
Copy link
Copy Markdown
Contributor

@marcospri
Copy link
Copy Markdown
Contributor Author

From claude, with the change long in context:

The lxml usage in this repo is just two files, both calling ET.XML() and ET.tostring(). None of the changelog's breaking changes touch those APIs:

  - The XXE fix (6.1.0) only applies to iterparse() and ETCompatXMLParser — not used here. ET.XML() has used resolve_entities='internal' (safe) since lxml 5.0.
  - lxml.html.clean moved to a separate package (5.2.0) — not used.
  - MemDebug.dump/show() removed (6.0.0) — not used.
  - strip_cdata deprecated on HTMLParser (5.3.0) — the HTMLParser in inbox/util/html.py is Python stdlib's, not lxml's.
  - Python < 3.8 support removed (6.0.0) — not a concern.

  No compatibility changes are needed. The upgrade is clean as-is.

@marcospri marcospri self-assigned this May 14, 2026
@wojcikstefan
Copy link
Copy Markdown
Member

We should observe Sentry closely after this deploys just in case, but I agree the changelog looks innocent given our usage.

@marcospri marcospri merged commit 5b736aa into master May 14, 2026
4 checks passed
@marcospri marcospri deleted the update-lxml branch May 14, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants