Skip to content

fix(script): use data2 as default hashType for data ref - #313

Merged
RetricSu merged 1 commit into
developfrom
use-data2
Dec 2, 2025
Merged

fix(script): use data2 as default hashType for data ref#313
RetricSu merged 1 commit into
developfrom
use-data2

Conversation

@RetricSu

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects the default hashType from 'data1' to 'data2' for data hash references across the codebase. When scripts don't have a type ID, they use a data hash, and this change ensures the correct hash type identifier is used.

  • Updated all conditional logic that sets hashType to 'data2' instead of 'data1' when using data hashes
  • Applied the correction to both testnet and mainnet configurations for the secp256k1_blake160_multisig_all_v2 script
  • Ensured consistency across utility functions that generate script info from deployment recipes

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/scripts/util.ts Updated getScriptInfoFrom to use 'data2' as hashType when typeId is not present
src/scripts/public.ts Corrected hashType from 'data1' to 'data2' for secp256k1_blake160_multisig_all_v2 in both TESTNET_SYSTEM_SCRIPTS and MAINNET_SYSTEM_SCRIPTS
src/cmd/system-scripts.ts Updated systemCellToScriptInfo function to use 'data2' hashType for both code and depGroup cases when type_hash is not present

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@RetricSu
RetricSu merged commit 9baa518 into develop Dec 2, 2025
8 checks passed
@RetricSu
RetricSu deleted the use-data2 branch December 2, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants