Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects the default hashType from 'data1' to 'data2' for data hash references across the codebase. When scripts don't have a type ID, they use a data hash, and this change ensures the correct hash type identifier is used.
- Updated all conditional logic that sets hashType to 'data2' instead of 'data1' when using data hashes
- Applied the correction to both testnet and mainnet configurations for the secp256k1_blake160_multisig_all_v2 script
- Ensured consistency across utility functions that generate script info from deployment recipes
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/scripts/util.ts | Updated getScriptInfoFrom to use 'data2' as hashType when typeId is not present |
| src/scripts/public.ts | Corrected hashType from 'data1' to 'data2' for secp256k1_blake160_multisig_all_v2 in both TESTNET_SYSTEM_SCRIPTS and MAINNET_SYSTEM_SCRIPTS |
| src/cmd/system-scripts.ts | Updated systemCellToScriptInfo function to use 'data2' hashType for both code and depGroup cases when type_hash is not present |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.