Conversation
RetricSu
changed the title
This was referenced Jul 8, 2026
humble-little-bear
added a commit
to humble-little-bear/offckb
that referenced
this pull request
Jul 11, 2026
- Replace execSync shell interpolation with spawnSync array args (CRIT ckb-devrel#1) - Add path validation for tools.rootFolder bounded to dataPath (CRIT ckb-devrel#3) - Add SHA-256 checksum verification for downloaded binaries (CRIT ckb-devrel#2) - Use -fsSL flags on curl, add timeouts, use fs.chmodSync, findFileInFolder - Fix deepMerge mutation by cloning defaultSettings before merge - Add settings validation for tools.rootFolder, ckbTui.version, proxy types - Fix status help text typo and use validateNetworkOpt() consistently - Replace nested ternary with lookup table, propagate exit code
RetricSu
pushed a commit
that referenced
this pull request
Jul 11, 2026
* feat(cmd): add status command with ckb-tui v0.1.3 Integrates ckb-tui to provide a terminal UI for monitoring CKB network status from a local node. Changes: - Add CKBTui class with automatic binary download/install for v0.1.3 - Add status command with RPC port connectivity check - Update settings schema with tools.rootFolder and ckbTui.version - Register status command in CLI with network validation Closes RET-161 * fix: address review feedback (round 1) - Replace execSync shell interpolation with spawnSync array args (CRIT #1) - Add path validation for tools.rootFolder bounded to dataPath (CRIT #3) - Add SHA-256 checksum verification for downloaded binaries (CRIT #2) - Use -fsSL flags on curl, add timeouts, use fs.chmodSync, findFileInFolder - Fix deepMerge mutation by cloning defaultSettings before merge - Add settings validation for tools.rootFolder, ckbTui.version, proxy types - Fix status help text typo and use validateNetworkOpt() consistently - Replace nested ternary with lookup table, propagate exit code * fix: add non-TTY guard to status command to prevent CI/pipe hangs (round 2)
This was referenced Jul 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.