Extended button with success and failed icon size property #56
Open
uzzero wants to merge 2 commits intochrisedg87:masterfrom
Open
Extended button with success and failed icon size property #56uzzero wants to merge 2 commits intochrisedg87:masterfrom
uzzero wants to merge 2 commits intochrisedg87:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extended the class with a success and failed icon size property. Icon sizes were always set to the default icon size (in most cases 24.0 px) which did look bad when rounded loading is very big (or very small). Fixed by providing an icon size which can be customized or set to the default value of 24.