Skip to content

🧪📦 Open release PRs with gh pr create - #864

Draft
webknjaz wants to merge 1 commit into
cherrypy:mainfrom
webknjaz:maintenance/pip-tools-create-pull-request
Draft

webknjaz wants to merge 1 commit into
cherrypy:mainfrom
webknjaz:maintenance/pip-tools-create-pull-request

Conversation

@webknjaz

@webknjaz webknjaz commented Nov 1, 2026

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

  • 🐞 bug fix
  • 🐣 feature
  • 📋 docs update
  • 📋 tests/coverage improvement
  • 📋 refactoring
  • 💥 other

What do these changes do?

This replaces the Docker-based vsoch/pull-request-action with a direct gh pr create invocation. The release branch and tag are still pushed atomically beforehand, and the step keeps exposing the same pull_request_number and pull_request_url outputs, so the rest of the job is unchanged.

peter-evans/create-pull-request is not used here on purpose: it rebuilds the PR branch on top of the base branch tip, which would detach the changelog commit from the tagged release committish.

Are there changes in behavior for the user?

nope

Is it a substantial burden for the maintainers to support this?

nah

Related issue number

n/a

Checklist

Tip

New to open source contributions? Making a lovely PR is a great read.

  • I wrote descriptive pull request text above
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences
  • I think the code is well written
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Project documentation (in docs/) and inline docstrings reflect the changes
  • My commits each have a descriptive title and a body explaining the why
    (see good commit messages)
  • I have added a change log entry
    (can be done once the PR number is known; alternatively, you can
    use a related issue number if one exists)
  • I'm planning to squash related commits together before final merge
  • I have read the contribution guide and the
    code of conduct

This replaces the Docker-based `vsoch/pull-request-action` with a
direct `gh pr create` invocation. The release branch and tag are
still pushed atomically beforehand, and the step keeps exposing the
same `pull_request_number` and `pull_request_url` outputs, so the
rest of the job is unchanged.

`peter-evans/create-pull-request` is not used here on purpose: it
rebuilds the PR branch on top of the base branch tip, which would
detach the changelog commit from the tagged release committish.

Assisted-by: LLM
@webknjaz webknjaz self-assigned this Nov 1, 2026
@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 cheroot | 🛠️ Build #35551934 | 📁 Comparing 58c7c2e against latest (4863ab6)

  🔍 Preview build  

2 files changed
± history/index.html
± pkg/cheroot.server/index.html

@codecov

codecov Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.20%. Comparing base (4863ab6) to head (58c7c2e).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #864   +/-   ##
=======================================
  Coverage   78.20%   78.20%           
=======================================
  Files          41       41           
  Lines        4791     4791           
  Branches      548      548           
=======================================
  Hits         3747     3747           
  Misses        905      905           
  Partials      139      139           

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant