Skip to content

feat(integrations): mark SMTP password and Dependency-Track API key as password #3117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Piskoo wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −4
Open

feat(integrations): mark SMTP password and Dependency-Track API key as password #3117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0329a5
feat(integrations): mask SMTP password and Dependency-Track API key
Piskoo May 14, 2026
ca02ed8
regen readme
Piskoo May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/controlplane/plugins/core/dependency-track/v1/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ See https://docs.chainloop.dev/guides/dependency-track/
|Field|Type|Required|Description|
|---|---|---|---|
|allowAutoCreate|boolean|no|Support of creating projects on demand|
|apiKey|string|yes|The API key to use for authentication|
|apiKey|string (password)|yes|The API key to use for authentication|
|instanceURI|string (uri)|yes|The URL of the Dependency-Track instance|

```json
Expand All @@ -25,6 +25,7 @@ See https://docs.chainloop.dev/guides/dependency-track/
},
"apiKey": {
"type": "string",
"format": "password",
"description": "The API key to use for authentication"
},
"allowAutoCreate": {
Expand Down
2 changes: 1 addition & 1 deletion app/controlplane/plugins/core/dependency-track/v1/extension.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ type DependencyTrack struct {
type registrationRequest struct {
// The URL of the Dependency-Track instance
InstanceURI string `json:"instanceURI" jsonschema:"format=uri,description=The URL of the Dependency-Track instance"`
APIKey string `json:"apiKey" jsonschema:"description=The API key to use for authentication"`
APIKey string `json:"apiKey" jsonschema:"format=password,description=The API key to use for authentication"`
Copy link
Copy Markdown
Member

@migmartri migmartri May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, does this updates the generated json schema?

Copy link
Copy Markdown
Collaborator Author

@Piskoo Piskoo May 14, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it does

// Support the option to automatically create projects if requested (optional)
AllowAutoCreate bool `json:"allowAutoCreate,omitempty" jsonschema:"description=Support of creating projects on demand"`
}
Expand Down
3 changes: 2 additions & 1 deletion app/controlplane/plugins/core/smtp/v1/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Starting now, every time a workflow run occurs, an email notification will be se
|---|---|---|---|
|from|string (email)|yes|The email address of the sender.|
|host|string|yes|The host to use for the SMTP authentication.|
|password|string|yes|The password to use for the SMTP authentication.|
|password|string (password)|yes|The password to use for the SMTP authentication.|
|port|string|yes|The port to use for the SMTP authentication|
|to|string (email)|yes|The email address to send the email to.|
|user|string|yes|The username to use for the SMTP authentication.|
Expand All @@ -58,6 +58,7 @@ Starting now, every time a workflow run occurs, an email notification will be se
},
"password": {
"type": "string",
"format": "password",
"description": "The password to use for the SMTP authentication."
},
"host": {
Expand Down
2 changes: 1 addition & 1 deletion app/controlplane/plugins/core/smtp/v1/extension.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ type registrationRequest struct {
To string `json:"to" jsonschema:"format=email,description=The email address to send the email to."`
From string `json:"from" jsonschema:"format=email,description=The email address of the sender."`
User string `json:"user" jsonschema:"minLength=1,description=The username to use for the SMTP authentication."`
Password string `json:"password" jsonschema:"description=The password to use for the SMTP authentication."`
Password string `json:"password" jsonschema:"format=password,description=The password to use for the SMTP authentication."`
Host string `json:"host" jsonschema:"description=The host to use for the SMTP authentication."`
// TODO: Make the port an integer
Port string `json:"port" jsonschema:"description=The port to use for the SMTP authentication"`
Expand Down
Loading