Skip to content

Skip timezone related conformance tests on Windows only #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
May 6, 2026
Merged

Skip timezone related conformance tests on Windows only #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions conformance/conformance_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,13 @@ class ConformanceTestSuite(unittest.TestSuite):
"optionals/optionals/optional_struct_optindex_index_value",
"optionals/optionals/optional_struct_optindex_value",
"optionals/optionals/struct_optindex_value",
# TODO(b/507568865): Timezone support on Windows.
"timestamps/timestamp_selectors_tz/.*",
]

if os.name == "nt":
# TODO(b/507568865): These tests depend on configuring a timezone database
# which isn't available in our windows test environment.
SKIP_TESTS.append("timestamps/timestamp_selectors_tz/.*")

def __init__(self):
super().__init__(self)
self._load_tests()
Expand Down
5 changes: 4 additions & 1 deletion custom_ext/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@ py_library(
data = [
"//cel_expr_python:cel",
],
deps = ["//cel_expr_python:cel"],
deps = select({
"@platforms//os:windows": [],
"//conditions:default": ["//cel_expr_python:cel"],
}),
)

py_test(
Expand Down
Loading