Permission error message not localised for non-English locales#549
Open
PujaDeshmukh17 wants to merge 6 commits into
Open
Permission error message not localised for non-English locales#549PujaDeshmukh17 wants to merge 6 commits into
PujaDeshmukh17 wants to merge 6 commits into
Conversation
PujaDeshmukh17
temporarily deployed
to
pr-analysis
July 20, 2026 08:37 — with
GitHub Actions
Inactive
PujaDeshmukh17
temporarily deployed
to
pr-analysis
July 20, 2026 08:37 — with
GitHub Actions
Inactive
PujaDeshmukh17
temporarily deployed
to
pr-analysis
July 20, 2026 08:41 — with
GitHub Actions
Inactive
PujaDeshmukh17
temporarily deployed
to
pr-analysis
July 20, 2026 08:41 — with
GitHub Actions
Inactive
…Fix-Feature' into RBSDMS-MessageErrorFix-Feature
PujaDeshmukh17
temporarily deployed
to
pr-analysis
July 20, 2026 08:51 — with
GitHub Actions
Inactive
PujaDeshmukh17
temporarily deployed
to
pr-analysis
July 20, 2026 08:51 — with
GitHub Actions
Inactive
PujaDeshmukh17
temporarily deployed
to
pr-analysis
July 20, 2026 08:57 — with
GitHub Actions
Inactive
PujaDeshmukh17
temporarily deployed
to
pr-analysis
July 20, 2026 08:57 — with
GitHub Actions
Inactive
PujaDeshmukh17
temporarily deployed
to
pr-analysis
July 20, 2026 14:43 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Problem:
When a user without upload permissions attempted to attach a file, the error popup always displayed in English regardless of the user's locale:
"You do not have the required permissions to upload attachments. Please contact your administrator for access."
Root Cause:
Hardcoded call site in SDMServiceImpl.java
One specific throw site in the getObject method (403 response branch) used the raw Java constant SDMConstants.USER_NOT_AUTHORISED_ERROR directly, bypassing the SDMUtils.getErrorMessage() lookup that all other throw sites use.
Any documentation
Type of change
Please delete options that are not relevant.
Checklist before requesting a review
Upload Screenshots/lists of the scenarios tested