Skip to content

docs: say none stays still under reduced motion (BON-16) - #52

Merged
hunterbecton merged 1 commit into
mainfrom
hunter/bon-16-docs-none-stays-still
Aug 28, 2026
Merged

docs: say none stays still under reduced motion (BON-16)#52
hunterbecton merged 1 commit into
mainfrom
hunter/bon-16-docs-none-stays-still

Conversation

@hunterbecton

@hunterbecton hunterbecton commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #51, which merged before this commit was pushed. examples.mdx still said Bones uses pulse under prefers-reduced-motion: reduce regardless of which animation you set. That contradicts the none scope, which has no reduced-motion override (pinned by packages/bones/tests/bones-css.test.ts). The sentence now says the default and shimmer become pulse, and none stays still.

CodeRabbit raised this on #51.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Clarified reduced-motion behavior: when enabled, default animations and shimmer effects use a pulse animation, while static animations remain unchanged.

CodeRabbit on PR #51: examples.mdx still said pulse applies regardless
of the animation you set, which contradicts the none scope having no
reduced-motion override.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 39c412bf-f7a5-465f-be6a-9fbf469e9d64

📥 Commits

Reviewing files that changed from the base of the PR and between dc790c3 and 0297a01.

📒 Files selected for processing (1)
  • apps/docs/content/docs/examples.mdx

Limit details: You’ve used the included review currently available.


📝 Walkthrough

Walkthrough

The documentation updates reduced-motion behavior. Default and shimmer animations use pulse. The none setting remains static.

Changes

Reduced-motion documentation

Layer / File(s) Summary
Document animation behavior
apps/docs/content/docs/examples.mdx
The reduced-motion guidance states that default and shimmer use pulse, while none remains static.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 0297a

This localized documentation update clarifies reduced-motion behavior for the default animation, shimmer, and none; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the documentation change for reduced-motion behavior.
Description check ✅ Passed The description explains the change, its purpose, and its alignment with existing tests. It omits the required Testing section, but the core description is complete.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hunter/bon-16-docs-none-stays-still

Usage-based review receipt

Note

This review was completed with usage-based billing: files reviewed beyond your plan's included limits are billed at $0.25/file. Track spend and usage in your billing settings.


Comment @coderabbitai help to get the list of available commands.

@hunterbecton
hunterbecton merged commit fc9d735 into main Aug 28, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant