Skip to content

feat(agent-device): --os and --image-tag reach lease.request - #840

Merged
V3RON merged 22 commits into
mainfrom
task/828
Oct 21, 2026
Merged

V3RON merged 22 commits into
mainfrom
task/828

Conversation

@V3RON

@V3RON V3RON commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Closes #828

Status

Implement: done (10/10 green) Review: passed (round 1 + fix-check, 1 finding fixed) Hardware: n/a Gate: waiting for the stack
Next: gate on the stack top (#840)

Done when

Feature #814 completion conditions (rule 9), using the tests the spec names as stand-ins until callstack/agent-device#3864 ships:

  • iOS --os through a worker and a gateway, reply names model and OS: edge.test.ts B1, B5 and gateway-front.test.ts B10.
  • Android --os 34 --image-tag: B2, B5.
  • Bad range, iOS image tag (with and without a model), missing runtime refused with Simlock's message, no lease: B3.
  • physical: true and an unmapped target refused, no lease: B7, B8.
  • The daemon never gets either key: B4, B6.
  • Docs, manual and ADR 0023: Done when line 3.

Assumptions

none

Review

Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 1 blocking, 1 fixed, 0 notes. Claims review: 0 blocking, 0 fixed, 0 notes.
Rounds: 1. Tokens: 2.5M.
Runs: 6. Cost USD: 2.6353. Agent seconds: 5780.
Assessment: complete

Written by an agent.

V3RON added 20 commits October 21, 2026 19:14
@V3RON

V3RON commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

Review ledger

Round 1: 0500152
Round fix-check: a97aa7a

Runs: 6. Cost USD: 2.6353. Agent seconds: 5780.
Tokens input 250, output 52606, cache read 6199230, cache write 595508.
- build implementer: claude-sonnet-5-5 1032 s $0.9302
- audit implementer: claude-sonnet-5-5 3780 s $1.1275
- review 1 reviewer: claude-sonnet-5-5 352 s $0.228
- fix 1 implementer: claude-sonnet-5-5 82 s $0.0822
- fix 1 implementer: claude-sonnet-5-5 507 s $0.1763
- review fix-check reviewer: claude-sonnet-5-5 27 s $0.0911
Finding outcomes: {"fixed":1}. Classes: {"architecture 17: false why comment":1}.
{"findings":[{"id":"R1","role":"code","class":"architecture 17: false why comment","outcome":"fixed","path":"src/agent-device/front/request-rules.ts","round":"1","fix":"a97aa7abeb833a8e745e3e5b8cf9acdd2072a3e7"}]}

R1 verified by: coordinator (comment-only hunk) at a97aa7a.

Written by an agent.

@V3RON
V3RON marked this pull request as ready for review October 21, 2026 18:46
@V3RON
V3RON merged commit 13913a6 into main Oct 21, 2026
27 of 28 checks passed
@V3RON
V3RON deleted the task/828 branch October 21, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

agent-device allocate carries --os and --image-tag to Simlock and answers the granted device

1 participant