Repository navigation
chore(agent-device): require agent-device 0.21.28 and take its proxy from npm - #603
Merged
Merged
Conversation
…from npm agent-device 0.21.28 is the first release with every change simlock's edge relies on, so the vendored integration-branch proxy goes and the version check moves from 0.21.25 to 0.21.28. A prerelease of the minimum now counts as older than it. The released proxy refuses install_from_source and release_materialized_paths from a tenant, so simlock's front refuses them too instead of forwarding them.
V3RON
marked this pull request as ready for review
October 15, 2026 12:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agent-device 0.21.28 is the first release with all eight simlock PRs (0.21.27 has only callstack/agent-device#3478). simlock now takes
@agent-device/proxy0.21.28 from npm, deletesvendor/, and requires agent-device 0.21.28 or later.0.21.28-nightly.20261013.49predates most of the PRs.commandandlease.*from an authenticated tenant. The front now refusesinstall_from_sourceandrelease_materialized_pathsitself. The agent-device CLI sends installs ascommand, so the CLI is unaffected.SIMLOCK_E2E_AGENT_DEVICEmust point at an install of the pinned version (npm i -g agent-device@0.21.28or a checkout atv0.21.28), no longer at a commit.Slow lane not run.
Review
Spec review: skipped. Code review: 1 blocking, 1 fixed, 0 notes. Claims review: 0 blocking, 0 fixed, 0 notes.
Rounds: 1. Tokens: n/a.
isVersionAtLeasthad an untested|| needed.prereleasebranch no caller reaches; dropped.Written by an agent.