Repository navigation
fix(drawer): let Drawer.Item grow with its label at large text sizes - #5275
Open
Priyanshu0007 wants to merge 1 commit into
Open
Priyanshu0007 wants to merge 1 commit into
Priyanshu0007 wants to merge 1 commit into
Conversation
Drawer.Item had a fixed 56dp height, so at the largest accessibility text sizes the label spilled out of the active indicator and into the next item. The item now has a 56dp minimum height and 8dp vertical padding, so it and its indicator grow with the label. At default text sizes it is still 56dp tall. Fixes callstack#5248
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Drawer.Itemhad a fixed 56dp height. At the largest accessibility text sizes, the label spilled out of the active indicator and into the next item. The item now has a 56dp minimum height and 8dp vertical padding, so it and its indicator grow with the label. At default text sizes it is still 56dp tall.Related issue
Fixes #5248
Screenshots / Videos
Android



iOS
Web
Test plan
Sign in(active),Sign upandAbout.xcrun simctl ui <device> content_size accessibility-extra-extra-extra-large.