Skip to content

fix(drawer): let Drawer.Item grow with its label at large text sizes - #5275

Open
Priyanshu0007 wants to merge 1 commit into
callstack:mainfrom
Priyanshu0007:fix/drawer-item-large-text
Open

Priyanshu0007 wants to merge 1 commit into
callstack:mainfrom
Priyanshu0007:fix/drawer-item-large-text

Conversation

@Priyanshu0007

Copy link
Copy Markdown

Motivation

Drawer.Item had a fixed 56dp height. At the largest accessibility text sizes, the label spilled out of the active indicator and into the next item. The item now has a 56dp minimum height and 8dp vertical padding, so it and its indicator grow with the label. At default text sizes it is still 56dp tall.

Related issue

Fixes #5248

Screenshots / Videos

Android
android
iOS
ios
Web
web

Test plan

  1. Render a 220dp drawer with Sign in (active), Sign up and About.
  2. Run xcrun simctl ui <device> content_size accessibility-extra-extra-extra-large.
  3. Each label stays inside its item.

Drawer.Item had a fixed 56dp height, so at the largest accessibility text
sizes the label spilled out of the active indicator and into the next item.

The item now has a 56dp minimum height and 8dp vertical padding, so it and its
indicator grow with the label. At default text sizes it is still 56dp tall.

Fixes callstack#5248

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drawer.Item: the label overflows the item at the largest accessibility text sizes

1 participant