Repository navigation
docs(example): add aria-labels to icon buttons - #5241
Open
mitar-drazic-ck wants to merge 1 commit into
Open
mitar-drazic-ck wants to merge 1 commit into
mitar-drazic-ck wants to merge 1 commit into
Conversation
|
Found potential problems with the pull request:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The icon-only buttons on the example app's Icon Button screen have no accessible name. Screen readers announce each one only as "button", and axe-core on the web reports a critical
button-nameviolation ("Buttons must have discernible text"). Each button now has anaria-labelthat says what it does.Related issue
Example app: icon-only IconButtons on the Icon Button screen have no accessible name
Fixes #5182
yarn install, thennpx expo start --webinexample/)./icon-button).button-name(critical).Screenshots / Videos
No visual change.

Test plan
/icon-button.button-nameviolation.