Repository navigation
feat: modernize RadioButton for MD3 #5007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
6221077
a155b74
015baf4
9649647
9e4a668
d9f3973
ee00e84
c0e1c18
e486e99
2b4eebb
1d1ea02
3c226a1
ea2a6e9
a1a3e75
feb9a54
5554631
12644a8
e0366bc
4008f1a
12e10e1
1fc4903
98786fd
af9cb8c
4bb43cd
ec36997
a427945
3578b0d
cbb7784
f9aff80
d307880
e51f07f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -104,27 +104,17 @@ | |
| 'without icons': 'screenshots/menu-2.png', | ||
| }, | ||
| 'Menu.Item': 'screenshots/menu-item.png', | ||
| Modal: 'screenshots/modal.gif', | ||
| ProgressBar: 'screenshots/progress-bar.png', | ||
| RadioButton: { | ||
| 'Android (enabled)': 'screenshots/radio-enabled.android.png', | ||
| 'Android (disabled)': 'screenshots/radio-disabled.android.png', | ||
| 'iOS (enabled)': 'screenshots/radio-enabled.ios.png', | ||
| 'iOS (disabled)': 'screenshots/radio-disabled.ios.png', | ||
| }, | ||
| 'RadioButton.Android': { | ||
| enabled: 'screenshots/radio-enabled.android.png', | ||
| disabled: 'screenshots/radio-disabled.android.png', | ||
| }, | ||
|
Comment on lines
107
to
112
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Minor · v5-only This PR deletes DetailsAlso raised hereAlso raised at this location by persona persona: Useful? Reply Reply |
||
| 'RadioButton.Group': { | ||
| Android: 'screenshots/radio-button-group-android.gif', | ||
| iOS: 'screenshots/radio-button-group-ios.gif', | ||
| }, | ||
| 'RadioButton.IOS': { | ||
| enabled: 'screenshots/radio-enabled.ios.png', | ||
| disabled: 'screenshots/radio-disabled.ios.png', | ||
| }, | ||
| 'RadioButton.Item': 'screenshots/radio-item.ios.png', | ||
|
Check warning on line 117 in docs/src/data/screenshots.ts
|
||
|
jacekAtCK marked this conversation as resolved.
Resolved
|
||
| Searchbar: { | ||
| bar: 'screenshots/searchbar.png', | ||
| view: 'screenshots/searchbar-view.png', | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Minor · screenshotsV6 deletes the RadioButton.Item screenshot from the v6 docs; its stated 5.x justification doesn't hold
Deleting
screenshotsV6['RadioButton.Item']removes the only entry thatrender.ts:130looks up bydoc.title, so the v6RadioButton.Itempage now renders no<ScreenshotTabs>at all. The comment's justification—that 5.x iOS radio assets are still rendered from the shared map—is incorrect becausegenerate-5x-docs.tsbuilds its custom fields from the archived 5.x branch's owndocs/docusaurus.config.jsanddocs/src/data/screenshots.jsand never importscomponent-docs.config.ts. TheRadioButton.Groupoverride also replaces Android/iOS tab data with a single string.Details
Also raised here
Also raised at this location by persona
react-native-paper: V6 RadioButton.Item doc page loses its screenshot, RadioButton keeps a v5 asset —docs/component-docs.config.tsdeletes'RadioButton.Item'fromscreenshotsV6, so the generated 6.xRadioButton.Itempage renders no screenshot at all even though the component changed its row height (52→64dp) and a11y structure in this PR — the one place a reviewer would see the new row. Meanwhile theRadioButtonentry still points atscreenshots/radio-enabled.android.png/radio-disabled.android.png, captures of the 36dp control this PR replaced with the 48dp one. Ship refreshed v6 assets (or keep an explicit entry) for both pages instead of dropping one and reusing the other's stale image.persona:
senior-developer,react-native-paperUseful? Reply
@apex-sentinel-staging like, or@apex-sentinel-staging dislike <why>if it is not.Reply
@apex-sentinel-staging note ...to add context, or@apex-sentinel-staging pivot ...if it is wrong — I will re-check the cited code.