You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Measuring custom tab bar height fails for absolutely‑positioned elements #380
This works for most layouts, but breaks whenever the returned element is absolutely positioned, since absolutely‑positioned children don’t contribute to their parent’s measured size.
Drop the manual .measure()/ref approach and rely solely on the native onLayout callback, injecting it directly into the custom tab bar element. For example:
Activity
Code-Victor commentedon Jul 7, 2025
Proposed Solution:
Drop the manual
.measure()/ref approach and rely solely on the nativeonLayoutcallback, injecting it directly into the custom tab bar element. For example:Why this works:
onLayoutfires reliably for absolutely‑positioned views, reporting their true dimensions.No extra wrapper is needed, so you measure the actual element itself.
Removes complexity around
refmanagementQuestions:
Does this fit with the library’s philosophy and coding conventions?
Would you like a PR that replaces the current wrapper+ref logic with this
onLayout‑based approach?I’d be happy to draft and submit one!