[nihgwu]

Motivation

better version of #1420 which modified external namespace globally
we see error like Property 'children' is missing in type '...' but required in type 'Props'. (ts 2741) everywhere in a project using React 17, although it's working fine with projects using React 18 and React 19

Summary

Test plan

[changeset-bot]

🦋 Changeset detected

Latest commit: ea223e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages

Name	Type
@linaria/react	Patch
@linaria/atomic	Patch
linaria	Patch
@linaria/testkit	Patch
linaria-website	Patch
esbuild-example	Patch
rollup-example	Patch
vite-example	Patch
webpack5-example	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[nihgwu]

@Anber Hi can you check, this is a blocker for us, otherwise we will need to lock to older version 🙏

[nihgwu]

@thymikee sorry for bothering, but this is critical for us, can't find an easy solution from our side 🙏

[thymikee]

Hey, I'm not maintaining this library, hope that @Anber can get to it when he's available :)

[Anber]

Thanks for the PR, and sorry it sat this long. The React 17 typing problem was fixed in #1465 and #1468 (released in 7.0.0 and 7.0.1), which cover the same case without @ts-expect-error and add a React 17 type test, so I'm closing this one as superseded.

I rechecked with @linaria/react 8.2.0 and React 17 types. With @types/react 17.0.59 or newer there are no errors with either "jsx": "react" or "jsx": "react-jsx". One case still fails: "jsx": "react" together with @types/react 17.0.58 or older, which predate React.JSX. There, a component that requires children still reports TS2741 once @linaria/react is imported; updating @types/react to ^17.0.59 or switching to "jsx": "react-jsx" avoids it.