fix(ios): bind Safari as the target app for simulator web-URL opens - #2761
Merged
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
|
Member
Author
|
Reviewed at 21640b8. The fix looks right: a simulator web-URL open now binds Not blocking: the body says launch mechanics do not change, but the bundle id now also turns on runner prewarm and the bridge-observation settle in The Coverage failure is the stale contact-sheet approval row in |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Opening a web URL on an iOS simulator (
open https://…) bound no app to the session, so the next interaction had no target. The runner then hitmissing_app_bundle, activated its own host app, and wedged until the 30s main-thread watchdog (main thread execution timed out), while the activation bounced Safari to Springboard. Physical-device opens already fall back tocom.apple.mobilesafari; the simulator branch did not.resolveIosBundleIdForOpennow returnsIOS_SAFARI_BUNDLE_IDfor a simulator web URL, mirroring the device branch.simctl openurlopens the URL in Safari regardless, so this only sets the session target app for later interactions; it does not change launch mechanics.Touched 3 files (1 source, 2 tests). No public-surface change; behavior parity with the device path.
Validation
Commit
21640b8de.pnpm check:affected --run: all runnable checks passed (292 files / 1761 tests).com.apple.mobilesafari(fails before the fix); the priorundefinedexpectation is replaced.open https://apex.callstack.comreportedApp: com.apple.mobilesafari;scroll down,fold half-open→fold open, andscroll bottomall succeeded and reached the footer. The previously-wedgingscrollsettled in ~1.7s.Unresolved risk: an
httpsURL claimed by a universal-link app instead of Safari is still assumed to be Safari — unchanged from the existing device web-open behavior.Runner-side fail-fast for interaction commands with no bundle is left as a separate follow-up to keep this PR scoped to the daemon.